Opened 7 years ago

Closed 7 years ago

#17931 closed enhancement (fixed)

Ref: add various missing modules to r/interfaces

Reported by: mmezzarobba Owned by:
Priority: major Milestone: sage-6.6
Component: documentation Keywords: reference, interfaces
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Julien Puydt
Report Upstream: N/A Work issues:
Branch: 753c038 (Commits, GitHub, GitLab) Commit: 753c038bf016083e439893522fbb77d6d2102ab0
Dependencies: Stopgaps:

Status badges

Description

Add missing modules to the Interfaces part of the reference manual.

Change History (16)

comment:1 Changed 7 years ago by mmezzarobba

  • Cc reference libraries removed
  • Keywords reference libraries added

comment:2 Changed 7 years ago by mmezzarobba

  • Keywords interfaces added; libraries removed

comment:3 Changed 7 years ago by git

  • Commit changed from c19f6ecf6610bc11452446ea1b0df8a2a8412735 to af01e452f4b6f39a715a051a9d35d5aac808b052

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

af01e45Ref: add various missing modules to r/interfaces

comment:4 Changed 7 years ago by mmezzarobba

  • Status changed from new to needs_review

comment:5 follow-up: Changed 7 years ago by Snark

  • Status changed from needs_review to needs_work

Hmmm... in the gfan page, in the AUTHOR section the first sentence about Anders Nedergaard Jensen doesn't look good -- and the one about Marshall Hampton doesn't either. And in the index of the interfaces, there's a big "MISSING TITLE" for magma free.

comment:6 Changed 7 years ago by Snark

Also, I find it strange that in the index of interfaces, 4ti2 comes with a link to the homepage of the project.

comment:7 Changed 7 years ago by Snark

Could you also, while you're at it, modify the title about the two Rubik's cube solvers, because there are three?

comment:8 Changed 7 years ago by mmezzarobba

Well, yes, the idea was to first include as many modules as possible and only then fix this kind of issues. But ok, since you took the pain of detailing the issues, I'll try to make things look a bit better already on this ticket. Thanks for your comments!

comment:9 Changed 7 years ago by Snark

Well, I don't think it would be very good to review something positively only to have the result reported as bad in another ticket :-/

comment:10 in reply to: ↑ 5 Changed 7 years ago by mmezzarobba

Replying to Snark:

Hmmm... in the gfan page, in the AUTHOR section the first sentence about Anders Nedergaard Jensen doesn't look good -- and the one about Marshall Hampton doesn't either.

Hmm, what is the problem with these sentences?

The rest should be fixed by the commit I'm going to push in a minute.

comment:11 Changed 7 years ago by git

  • Commit changed from af01e452f4b6f39a715a051a9d35d5aac808b052 to 753c038bf016083e439893522fbb77d6d2102ab0

Branch pushed to git repo; I updated commit sha1. New commits:

753c038Ref: add/fix module titles in r/interfaces

comment:12 Changed 7 years ago by mmezzarobba

  • Status changed from needs_work to needs_review

comment:13 Changed 7 years ago by Snark

  • Status changed from needs_review to positive_review

The sentence didn't seem right, but well : it looks good.

comment:14 Changed 7 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name missing

comment:15 Changed 7 years ago by Snark

  • Reviewers set to Julien Puydt
  • Status changed from needs_work to positive_review

comment:16 Changed 7 years ago by vbraun

  • Branch changed from u/mmezzarobba/ref-interfaces to 753c038bf016083e439893522fbb77d6d2102ab0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.