Opened 6 years ago

Closed 6 years ago

#17900 closed enhancement (fixed)

Setup interrupts in Cython

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: c_lib Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 1d41ca2 (Commits, GitHub, GitLab) Commit: 1d41ca2248be87c73a8cda9d21317bfa62dfb1bd
Dependencies: Stopgaps:

Status badges

Description

Instead of calling setup_sage_signal_handler() from stdsage.c, call it instead from Cython when importing sage.ext.interrupt (renamed from sage.ext.c_lib).

This also bypasses the initialization of the global_empty_tuple from stdsage.c, but that is no longer used since #17668.

Change History (13)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17900

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to bcead5d2a589f09912b4b7d1c83da3e8808d5099
  • Status changed from new to needs_review

Last 10 new commits:

9a2432fMerge tag '6.6.beta2' into t/17789/ticket/17789
745a3dbRemove declarations for ZZ_get_pylong/ZZ_set_pylong
145de10Move memory functions to Cython
91197b4Merge ticket/17881 into ticket/17789
564f839Move NTL error handler to Cython
e11e0e8Rename ntl/handle_error.pyx to ntl/error.pyx
4546327Add doctest to make coverage script happy
7f5bb61Fix docstring formatting
bc63b33Merge commit '91197b40bc6919fe1eacdb894a4478b9f12a24ea'; commit '7f5bb6171a8a386a8114e58de513751200db342e' into HEAD
bcead5dMove interrupt setup to src/sage/ext/interrupt.pyx

comment:3 Changed 6 years ago by git

  • Commit changed from bcead5d2a589f09912b4b7d1c83da3e8808d5099 to d1ef47f16b968e998d097becd966d33e7f8ab51c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d1ef47fMove interrupt setup to src/sage/ext/interrupt.pyx

comment:4 Changed 6 years ago by jdemeyer

  • Dependencies #17784, #17789 deleted

comment:5 Changed 6 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba
  • Status changed from needs_review to needs_work
  • Work issues set to doc

interrupt.pyx should probably be linked somewhere in the reference manual. Otherwise LGTM.

comment:6 Changed 6 years ago by mmezzarobba

Oh, and there is a comment still referring to c_lib.pyx in interrupt.c.

comment:7 Changed 6 years ago by git

  • Commit changed from d1ef47f16b968e998d097becd966d33e7f8ab51c to 0c5936bc4014b57b254ec17957045d60e30e06b6

Branch pushed to git repo; I updated commit sha1. New commits:

0c5936bAdd interrupt.pyx to the reference manual

comment:8 Changed 6 years ago by mmezzarobba

  • Status changed from needs_work to positive_review
  • Work issues doc deleted

comment:9 Changed 6 years ago by mmezzarobba

  • Status changed from positive_review to needs_work
  • Work issues set to merge

comment:10 Changed 6 years ago by mmezzarobba

Rebased on top of the current beta and fixed the mess with reference/libs/index.rst in public/17900-interrupt. Please change the branch on this ticket and set to positive review if this solution is okay with you.

comment:11 Changed 6 years ago by jdemeyer

  • Branch changed from u/jdemeyer/ticket/17900 to public/17900-interrupt
  • Commit changed from 0c5936bc4014b57b254ec17957045d60e30e06b6 to 1d41ca2248be87c73a8cda9d21317bfa62dfb1bd
  • Status changed from needs_work to needs_review
  • Work issues merge deleted

New commits:

cb3f90bMove interrupt setup to src/sage/ext/interrupt.pyx
1d41ca2Add interrupt.pyx to the reference manual

comment:12 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:13 Changed 6 years ago by vbraun

  • Branch changed from public/17900-interrupt to 1d41ca2248be87c73a8cda9d21317bfa62dfb1bd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.