Opened 5 years ago

Last modified 5 years ago

#17898 closed defect

Removal of wrong stopgap — at Initial Version

Reported by: aschilling Owned by:
Priority: major Milestone: sage-6.6
Component: combinatorics Keywords: stopgap, partitions
Cc: tscrim, nthiery, vdelecroix, jdemeyer Merged in:
Authors: Anne Schilling Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

As documented in http://trac.sagemath.org/ticket/17548 there are no reported bugs related to IntegerListsLex?. All cases listed on that ticket have non-valid input (as documented in the code).

Since the stopgap is not related to any bug and shows up in completely unrelated code, where IntegerListsLex? is correctly used, for example

sage: K = crystals.KirillovReshetikhin(['D',4,1],1,1)
/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/partition.py:4827:
********************************************************************************
This code contains bugs and may be mathematically unreliable.
This issue is being tracked at http://trac.sagemath.org/sage_trac/ticket/17548.
********************************************************************************

and

sage: Partitions(3,max_part=2)
/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/partition.py:6622:
********************************************************************************
This code contains bugs and may be mathematically unreliable.
This issue is being tracked at http://trac.sagemath.org/sage_trac/ticket/17548.
********************************************************************************
Partitions of 3 having parts less than or equal to 2

it should be removed.

Instead, either a check should be added to the code to check the user input or the IntegerListsLex? code should be extended to allow for all input.

Change History (0)

Note: See TracTickets for help on using tickets.