Changes between Initial Version and Version 1 of Ticket #17898, comment 24


Ignore:
Timestamp:
03/07/15 07:41:46 (4 years ago)
Author:
ncohen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17898, comment 24

    initial v1  
    1010If I understand the intent behind your patch, you believe that `IntegerListsLex` is used correctly by all of Sage's functions, and that we are only at risk when users call it directly, with possibly wrong input. Thus only the 'public' version of `IntegerListsLex` will raise the stopgap, and all internal calls will be silent. I believe that it is dangerous too, for many user-exposed functions call `IntegerListsLex`  (and so bypass `IntegerListsLexPublic`), and may also return wrong output. I am not sure that all internal calls to `IntegerListsLex` are safe and checked either.
    1111
    12 To answer one of your earlier question, I personally did not implement this conditional stopgap myself because I do not know any restriction of the parameters for which I could swear that only trustworthy results will ever be returned. If you know such a combination and find a reviewer who double-checks it, however, that is a good way out for this ticket.
     12To answer one of your earlier question, I personally did not implement this conditional stopgap because I do not know any restriction of the parameters for which I could swear that only trustworthy results will ever be returned. If you know such a combination and find a reviewer who double-checks it, however, that is a good way out for this ticket.
    1313
    1414Nathann