Opened 4 years ago

Closed 4 years ago

#17897 closed defect (fixed)

Jsonschema package

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.6
Component: packages: optional Keywords:
Cc: fbissey Merged in:
Authors: Volker Braun Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 4bb5eb0 (Commits) Commit: 4bb5eb0714d928b79f01b7192e6c6889f519aac4
Dependencies: Stopgaps:

Description (last modified by vbraun)

The IPython 3.0 notebook depends on jsonschema

Tarballs are already on the sage mirror

Change History (18)

comment:1 Changed 4 years ago by vbraun

  • Branch set to u/vbraun/jsonschema_package

comment:2 Changed 4 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 124fd07c86452a2fe339d8a7c79c8372c9729bf0
  • Component changed from PLEASE CHANGE to packages: optional
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Jsonschema package to Jsonschema and jsonpointer package
  • Type changed from PLEASE CHANGE to defect

New commits:

fd3ebd5Initial addition of jsonschema
124fd07Initial addition of jsonpointer

comment:3 Changed 4 years ago by vbraun

  • Cc fbissey added

comment:4 Changed 4 years ago by vbraun

  • Description modified (diff)

comment:5 Changed 4 years ago by git

  • Commit changed from 124fd07c86452a2fe339d8a7c79c8372c9729bf0 to 1bffae9de51d4cda89681f197f8ccacffbdf8086

Branch pushed to git repo; I updated commit sha1. New commits:

1bffae9make IPython depend on jsonpointer, jsonschema

comment:6 Changed 4 years ago by git

  • Commit changed from 1bffae9de51d4cda89681f197f8ccacffbdf8086 to 4e068151f6bc1426b41c1fe481cd2547a33ad35e

Branch pushed to git repo; I updated commit sha1. New commits:

4e06815Jsonschema and pointer are IPython runtime dependencies only

comment:7 Changed 4 years ago by fbissey

Is jsonpointer really necessary, I do not see it on my list of ipython 3 dependencies. But I have mistune (markdown support) for the notebook.

Is jsonpointer an optional package bringing extra features that we should know about?

comment:8 Changed 4 years ago by vbraun

I just read http://stackoverflow.com/questions/24211371/updating-ipython which says so, I haven't tried if it works without jsonpointer.

comment:9 Changed 4 years ago by fbissey

From setup.py in ipython 3

# setuptools requirements

pyzmq = 'pyzmq>=13'

extras_require = dict(
    parallel = [pyzmq],
    qtconsole = [pyzmq, 'pygments'],
    doc = ['Sphinx>=1.1', 'numpydoc'],
    test = ['nose>=0.10.1', 'requests'],
    terminal = [],
    nbformat = ['jsonschema>=2.0'],
    notebook = ['tornado>=4.0', pyzmq, 'jinja2', 'pygments', 'mistune>=0.5'],
    nbconvert = ['pygments', 'jinja2', 'mistune>=0.3.1']
)

if not sys.platform.startswith('win'):
    extras_require['notebook'].append('terminado>=0.3.3')

if sys.version_info < (3, 3):
    extras_require['test'].append('mock')

extras_require['notebook'].extend(extras_require['nbformat'])
extras_require['nbconvert'].extend(extras_require['nbformat'])

install_requires = []

# add readline
if sys.platform == 'darwin':
    if 'bdist_wheel' in sys.argv[1:] or not setupext.check_for_readline():
        install_requires.append('gnureadline')
elif sys.platform.startswith('win'):
    extras_require['terminal'].append('pyreadline>=2.0')

everything = set()
for deps in extras_require.values():
    everything.update(deps)
extras_require['all'] = everything

So I think jsonpointer is not necessary but mistune is. I checked the direct dependencies for jsonpointer but did not find anything.

comment:10 Changed 4 years ago by fbissey

In fact we may want to add terminado to that list.

comment:11 Changed 4 years ago by vbraun

Terminado is definitely optional... you can pip install it if you want the option for a web-based terminal but its not required.

comment:12 Changed 4 years ago by git

  • Commit changed from 4e068151f6bc1426b41c1fe481cd2547a33ad35e to 029694a2138c9dc156e0578a19f0ffb4a5b0f6ce

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

029694amake IPython depend on jsonschema

comment:13 Changed 4 years ago by vbraun

  • Description modified (diff)
  • Summary changed from Jsonschema and jsonpointer package to Jsonschema package

Looks like jsonpointer isn't necessary after all

comment:14 Changed 4 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to needs_work

jsonpointer is still in build/deps

comment:15 Changed 4 years ago by git

  • Commit changed from 029694a2138c9dc156e0578a19f0ffb4a5b0f6ce to 4bb5eb0714d928b79f01b7192e6c6889f519aac4

Branch pushed to git repo; I updated commit sha1. New commits:

4bb5eb0Forgot one jsonpointer occurrence

comment:16 Changed 4 years ago by vbraun

  • Status changed from needs_work to needs_review

fixed!


New commits:

4bb5eb0Forgot one jsonpointer occurrence

comment:17 Changed 4 years ago by fbissey

  • Status changed from needs_review to positive_review

All good.

comment:18 Changed 4 years ago by vbraun

  • Branch changed from u/vbraun/jsonschema_package to 4bb5eb0714d928b79f01b7192e6c6889f519aac4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.