Opened 8 years ago

Last modified 8 years ago

#17890 closed enhancement

Remove _(rich)cmp_c_impl — at Version 5

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.7
Component: cython Keywords:
Cc: Daniel Krenn Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/17890 (Commits, GitHub, GitLab) Commit: a830cc93c6bb07565db709bfe03f8acc62034dbb
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Instead of

    def _cmp_(left, right)
    cdef int _cmp_c_impl(left, right) except -2

we should have

    cpdef int _cmp_(left, right) except -2

Analogously for _richcmp_.

Attached branch passes all doctests, but is somewhat slower than before.

Change History (5)

comment:1 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Remove _cmp_c_implRemove _(rich)cmp_c_impl

comment:2 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/17890

comment:5 Changed 8 years ago by Jeroen Demeyer

Commit: a830cc93c6bb07565db709bfe03f8acc62034dbb
Description: modified (diff)

New commits:

7083f19Remove use of PY_IS_NUMERIC
7eb0e93Move py_scalar_to_element to coerce.pyx
8300f59trac #17862 (review): doc typo
a3ea57fMerge tag '6.6.beta2' into HEAD
a830cc9Remove _cmp_c_impl and _richcmp_c_impl
Note: See TracTickets for help on using tickets.