Opened 8 years ago
Closed 8 years ago
#17889 closed enhancement (fixed)
Unify base_extend, base_extend_c, base_extend_c_impl
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.6 |
Component: | cython | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | André Apitzsch |
Report Upstream: | N/A | Work issues: | |
Branch: | 9db1cf7 (Commits, GitHub, GitLab) | Commit: | 9db1cf7366356963af3f7e07f32af682bf1feb7d |
Dependencies: | Stopgaps: |
Description (last modified by )
Replace
cdef base_extend_c(self, Parent R): cdef base_extend_c_impl(self, Parent R): def base_extend(self, R):
by
cpdef base_extend(self, R):
Since base_extend_c
and base_extend_c_impl
aren't actually used anywhere, this is trivial.
Change History (5)
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 8 years ago by
Branch: | → u/jdemeyer/unify_base_extend__base_extend_c__base_extend_c_impl |
---|
comment:3 Changed 8 years ago by
Commit: | → 9db1cf7366356963af3f7e07f32af682bf1feb7d |
---|---|
Status: | new → needs_review |
comment:4 Changed 8 years ago by
Reviewers: | → André Apitzsch |
---|---|
Status: | needs_review → positive_review |
Looks good to me.
comment:5 Changed 8 years ago by
Branch: | u/jdemeyer/unify_base_extend__base_extend_c__base_extend_c_impl → 9db1cf7366356963af3f7e07f32af682bf1feb7d |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Remove base_extend_c and base_extend_c_impl