Opened 6 years ago

Closed 6 years ago

#17882 closed enhancement (fixed)

Cython clean-up in fast_eval.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 1b9fa85 (Commits, GitHub, GitLab) Commit: 1b9fa85ded3338992a4846fe9b67074f86dccac7
Dependencies: Stopgaps:

Status badges

Description

We remove the following line from stdsage.pxi:

ctypedef void PyObject

This requires fixing two Cython modules:

  1. src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx
  2. src/sage/ext/fast_eval.pyx

The latter is actually the non-trivial part of this ticket.

Change History (6)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17882
  • Commit set to 1b9fa85ded3338992a4846fe9b67074f86dccac7
  • Status changed from new to needs_review

New commits:

1b9fa85Remove wrong PyObject declaration from stdsage.pxi

comment:2 Changed 6 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

And I am putting that one to positive review too.

comment:3 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Author name is missing

comment:4 Changed 6 years ago by fbissey

  • Authors set to Jeroen Demeyer
  • Status changed from needs_work to needs_review

comment:5 Changed 6 years ago by fbissey

  • Status changed from needs_review to positive_review

Fixed for you.

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17882 to 1b9fa85ded3338992a4846fe9b67074f86dccac7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.