Opened 6 years ago
Closed 6 years ago
#17868 closed enhancement (fixed)
Add "indirect doctest" to the list of doctest flags
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  documentation  Keywords:  
Cc:  kcrisman, vdelecroix  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  df93def (Commits)  Commit:  df93def5e1d3803b0bdb4313cc9086c8dbad7852 
Dependencies:  Stopgaps: 
Description (last modified by )
This ticket adds a mention of indirect doctest
in the developer's manual.
Change History (16)
comment:1 Changed 6 years ago by
 Branch set to public/17868
 Commit set to 79896557cf8636ef063bc01299eaff0613374d04
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
What about an example? It would be especially meaningful for testing __add__
or __repr__
on some object.
Vincent
comment:3 Changed 6 years ago by
 Status changed from needs_review to needs_work
coverage
> coverage
comment:4 Changed 6 years ago by
Thanks for this  I had no idea this wasn't in the developer guide!
comment:5 Changed 6 years ago by
 Commit changed from 79896557cf8636ef063bc01299eaff0613374d04 to 2f6ec9a3878a792ae6e94a11e4295695c5dfd367
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
2f6ec9a  trac #17868: Add "indirect doctest" to the list of doctest flags

comment:6 Changed 6 years ago by
 Description modified (diff)
 Status changed from needs_work to needs_review
comment:7 followup: ↓ 9 Changed 6 years ago by
 Status changed from needs_review to needs_work
You should not use both "etc" and an ellipsis (ie "..."). You need to choose.
Why is there a comma here
calling ``B``, which ^ 
Vincent
comment:8 Changed 6 years ago by
 Commit changed from 2f6ec9a3878a792ae6e94a11e4295695c5dfd367 to eb26aaf697ce23b33a2b67bb3f67b00e387b08c2
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
eb26aaf  trac #17868: Add "indirect doctest" to the list of doctest flags

comment:9 in reply to: ↑ 7 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:10 followup: ↓ 11 Changed 6 years ago by
Good for me!
Vincent
comment:11 in reply to: ↑ 10 Changed 6 years ago by
Good for me!
Good enough for a positive review ? :P
Nathann
comment:12 Changed 6 years ago by
Beep ?...
comment:13 Changed 6 years ago by
 Commit changed from eb26aaf697ce23b33a2b67bb3f67b00e387b08c2 to df93def5e1d3803b0bdb4313cc9086c8dbad7852
comment:14 Changed 6 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
I have just changed the indentations. Positive review.
comment:15 Changed 6 years ago by
Works for me, thank you very much :)
Nathann
comment:16 Changed 6 years ago by
 Branch changed from public/17868 to df93def5e1d3803b0bdb4313cc9086c8dbad7852
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac #17868: Add "indirect doctest" to the list of doctest flags