Opened 5 years ago

Closed 5 years ago

#17868 closed enhancement (fixed)

Add "indirect doctest" to the list of doctest flags

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.6
Component: documentation Keywords:
Cc: kcrisman, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: df93def (Commits) Commit: df93def5e1d3803b0bdb4313cc9086c8dbad7852
Dependencies: Stopgaps:

Description (last modified by ncohen)

This ticket adds a mention of indirect doctest in the developer's manual.

Change History (16)

comment:1 Changed 5 years ago by ncohen

  • Branch set to public/17868
  • Commit set to 79896557cf8636ef063bc01299eaff0613374d04
  • Status changed from new to needs_review

New commits:

​7989655trac #17868: Add "indirect doctest" to the list of doctest flags

comment:2 Changed 5 years ago by vdelecroix

What about an example? It would be especially meaningful for testing __add__ or __repr__ on some object.

Vincent

comment:3 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

-coverage -> --coverage

Last edited 5 years ago by jdemeyer (previous) (diff)

comment:4 Changed 5 years ago by kcrisman

Thanks for this - I had no idea this wasn't in the developer guide!

comment:5 Changed 5 years ago by git

  • Commit changed from 79896557cf8636ef063bc01299eaff0613374d04 to 2f6ec9a3878a792ae6e94a11e4295695c5dfd367

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2f6ec9atrac #17868: Add "indirect doctest" to the list of doctest flags

comment:6 Changed 5 years ago by ncohen

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:7 follow-up: Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_work

You should not use both "etc" and an ellipsis (ie "..."). You need to choose.

Why is there a comma here 

calling ``B``, which
             ^
-------------|

Vincent

comment:8 Changed 5 years ago by git

  • Commit changed from 2f6ec9a3878a792ae6e94a11e4295695c5dfd367 to eb26aaf697ce23b33a2b67bb3f67b00e387b08c2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​eb26aaftrac #17868: Add "indirect doctest" to the list of doctest flags

comment:9 in reply to: ↑ 7 Changed 5 years ago by ncohen

  • Status changed from needs_work to needs_review
Last edited 5 years ago by ncohen (previous) (diff)

comment:10 follow-up: Changed 5 years ago by vdelecroix

Good for me!

Vincent

comment:11 in reply to: ↑ 10 Changed 5 years ago by ncohen

Good for me!

Good enough for a positive review ? :-P

Nathann

comment:12 Changed 5 years ago by ncohen

Beep ?...

comment:13 Changed 5 years ago by git

  • Commit changed from eb26aaf697ce23b33a2b67bb3f67b00e387b08c2 to df93def5e1d3803b0bdb4313cc9086c8dbad7852

Branch pushed to git repo; I updated commit sha1. New commits:

​90cb551Merge branch 'public/17868' into 6.6.b3
​df93deftrac #17868 indentation details

comment:14 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

I have just changed the indentations. Positive review.

comment:15 Changed 5 years ago by ncohen

Works for me, thank you very much :-)

Nathann

comment:16 Changed 5 years ago by vbraun

  • Branch changed from public/17868 to df93def5e1d3803b0bdb4313cc9086c8dbad7852
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.