Opened 7 years ago

Closed 7 years ago

#17863 closed enhancement (fixed)

Remove unused stuff from SAGE_ROOT/src/ext/

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.6
Component: scripts Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 475ce87 (Commits, GitHub, GitLab) Commit: 475ce87dd62c81953689cf800e10b58639d6bfa2
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

Just remove:

  • src/ext/maxima/*

The code is actually subsumed in recent version of maxima by a to_poly command in the module to_poly_solve.

Change History (7)

comment:1 Changed 7 years ago by vdelecroix

  • Branch set to u/vdelecroix/17863
  • Commit set to 8c0cf63c0e86d0cfc042149901ef9cfcde4d14ac
  • Component changed from misc to quadratic forms
  • Status changed from new to needs_review

New commits:

8c0cf63trac #17863: remove stuff from src/ext

comment:2 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to needs_work

The gap files are used by src/sage/groups/perm_gps/

comment:3 Changed 7 years ago by jdemeyer

  • Component changed from quadratic forms to scripts

comment:4 Changed 7 years ago by git

  • Commit changed from 8c0cf63c0e86d0cfc042149901ef9cfcde4d14ac to 475ce87dd62c81953689cf800e10b58639d6bfa2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

475ce87trac #17863: get rid of ext/maxima/*

comment:5 Changed 7 years ago by vdelecroix

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:6 Changed 7 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, all long tests pass.

comment:7 Changed 7 years ago by vbraun

  • Branch changed from u/vdelecroix/17863 to 475ce87dd62c81953689cf800e10b58639d6bfa2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.