Opened 6 years ago

Closed 6 years ago

#17853 closed enhancement (fixed)

Implement mpz <-> Python int/long in Cython

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: c_lib Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: ef9740c (Commits, GitHub, GitLab) Commit: ef9740cb55883de92096f089d93f681422cbb1f9
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Convert the c_lib file mpz_pylong.c to Cython. Also simplify the implementation a lot using mpz_import/mpz_export.

Together with #17789, this means we can completely remove the files

src/c_lib/include/mpn_pylong.h
src/c_lib/include/mpz_pylong.h
src/c_lib/include/ZZ_pylong.h
src/c_lib/src/mpn_pylong.c
src/c_lib/src/mpz_pylong.c
src/c_lib/src/ZZ_pylong.cpp

Change History (6)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17853

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 57b30f8cb719c8f57e0600c4333c8bbcca298461
  • Component changed from cython to c_lib
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

57b30f8Implement mpz <-> Python int/long in Cython

comment:3 Changed 6 years ago by git

  • Commit changed from 57b30f8cb719c8f57e0600c4333c8bbcca298461 to ef9740cb55883de92096f089d93f681422cbb1f9

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ef9740cImplement mpz <-> Python int/long in Cython

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Implement mpz_pylong in Cython to Implement mpz <-> Python int/long in Cython

comment:5 Changed 6 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Send the bots.

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17853 to ef9740cb55883de92096f089d93f681422cbb1f9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.