Opened 8 years ago

Closed 8 years ago

#17842 closed enhancement (fixed)

Show tracebacks in unpickle_all()

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.7
Component: pickling Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Jan Keitel
Report Upstream: N/A Work issues:
Branch: 1bb609e (Commits, GitHub, GitLab) Commit: 1bb609e987084b1fc08cd4d23ed7add21069adea
Dependencies: Stopgaps:

Status badges

Description

When unpickle_all() fails to unpickle a pickle from the pickle jar, a traceback should be shown.

Change History (9)

comment:1 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/17842
Created: Feb 23, 2015, 3:06:06 PMFeb 23, 2015, 3:06:06 PM
Modified: Feb 23, 2015, 3:06:06 PMFeb 23, 2015, 3:06:06 PM

comment:2 Changed 8 years ago by Jeroen Demeyer

Commit: 1bb609e987084b1fc08cd4d23ed7add21069adea
Status: newneeds_review

New commits:

1bb609eShow tracebacks in unpickle_all()

comment:3 Changed 8 years ago by Vincent Delecroix

Why did you remove the doctest in register_unpickle_override?

comment:4 in reply to:  3 Changed 8 years ago by Jeroen Demeyer

Replying to vdelecroix:

Why did you remove the doctest in register_unpickle_override?

Because that's a doctest for unpickle_global which somehow got copied into register_unpickle_override.

comment:5 Changed 8 years ago by Jeroen Demeyer

Please review...

comment:6 Changed 8 years ago by Jan Keitel

Hi Jeroen,

a naive question: Isn't that what the debug parameter in unpickle_all() is for?

comment:7 in reply to:  6 Changed 8 years ago by Jeroen Demeyer

Replying to jkeitel:

Hi Jeroen,

a naive question: Isn't that what the debug parameter in unpickle_all() is for?

Yes, except that

  1. debug is not on by default in the doctest.
  1. debug returns a list of tracebacks that you manually have to format using the traceback module.

My solution is way more user friendly (and debug is still supported if you want that).

comment:8 Changed 8 years ago by Jan Keitel

Milestone: sage-6.6sage-6.7
Reviewers: Jan Keitel
Status: needs_reviewpositive_review

Fair enough - seems to be useful information to have.

comment:9 Changed 8 years ago by Volker Braun

Branch: u/jdemeyer/ticket/178421bb609e987084b1fc08cd4d23ed7add21069adea
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.