Opened 8 years ago

Closed 8 years ago

#17841 closed enhancement (fixed)

--only-bad and --summary arguments for sage-coverage

Reported by: Vincent Delecroix Owned by:
Priority: major Milestone: sage-6.6
Component: scripts Keywords:
Cc: Thierry Monteil, Nathann Cohen Merged in:
Authors: Vincent Delecroix Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: f7f147a (Commits, GitHub, GitLab) Commit: f7f147a1c509ae71f6e68a5d8ae2128394a2f42d
Dependencies: Stopgaps:

Status badges

Description (last modified by Vincent Delecroix)

Add two arguments for sage-coverage

  • --only-bad to print only informations about bad files
  • --summary to print only a summary

We also introduce the usage of the argparse python module. Because of that we automatically win an extra option -h and a nice display of the help.

Attachments (1)

bad_files.txt (12.7 KB) - added by Vincent Delecroix 8 years ago.
output of sage-coverage --summary .

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by Vincent Delecroix

Branch: u/vdelecroix/17841
Commit: 6c5572a1fa16fc529594784d5fcea86df8c66fd8
Status: newneeds_review

comment:2 Changed 8 years ago by Vincent Delecroix

Description: modified (diff)

comment:3 Changed 8 years ago by git

Commit: 6c5572a1fa16fc529594784d5fcea86df8c66fd8c1359b2a3fc5336735af6815c16a200e658af0f1

Branch pushed to git repo; I updated commit sha1. New commits:

c1359b2trac #17841: enhanced sage-coverage

comment:4 Changed 8 years ago by git

Commit: c1359b2a3fc5336735af6815c16a200e658af0f1b9a2562f2b646c49d439cbb4d40d45f1555eabc4

Branch pushed to git repo; I updated commit sha1. New commits:

b9a2562trac #17841: remove the '-' in the summary

comment:5 Changed 8 years ago by git

Commit: b9a2562f2b646c49d439cbb4d40d45f1555eabc4caf841a9cb818cc54d1949a4b63a7fecb41ff780

Branch pushed to git repo; I updated commit sha1. New commits:

caf841atrac #17841: nb of files with bad doc in the summary

Changed 8 years ago by Vincent Delecroix

Attachment: bad_files.txt added

output of sage-coverage --summary .

comment:6 Changed 8 years ago by Vincent Delecroix

In bad_files.txt (= output of sage-coverage --summary $SAGE_ROOT/src/sage) one can see that we have

  • 401 files with wrong documentation
  • 1514 functions with no doc
  • 563 functions with no test
  • 310 doctest are potentially wrong

comment:7 Changed 8 years ago by git

Commit: caf841a9cb818cc54d1949a4b63a7fecb41ff780854f13d0940e24afa2dc04565d20a35ea8687516

Branch pushed to git repo; I updated commit sha1. New commits:

854f13dtrac #17841: show the global score in the summary

comment:8 Changed 8 years ago by Nathann Cohen

Reviewers: Nathann Cohen

I added a commit at public/17841. If that's fine for you, then I guess it can go.

Nathann

comment:9 Changed 8 years ago by Vincent Delecroix

Branch: u/vdelecroix/17841public/17841
Commit: 854f13d0940e24afa2dc04565d20a35ea8687516f7f147a1c509ae71f6e68a5d8ae2128394a2f42d

Your version did not work because of the variable first not being available.


New commits:

ad4cfd2trac #17841: Review
f7f147atrac #17841: missing "global first"

comment:10 Changed 8 years ago by Nathann Cohen

O_o

Weird.. I thought that I had run that script to test that ^^;;;

Nathann

comment:11 Changed 8 years ago by Nathann Cohen

Status: needs_reviewpositive_review

comment:12 Changed 8 years ago by Vincent Delecroix

Thanks!

(possibly you did not run it without any of the long option)

comment:13 Changed 8 years ago by Volker Braun

Branch: public/17841f7f147a1c509ae71f6e68a5d8ae2128394a2f42d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.