Opened 6 years ago
Closed 6 years ago
#17826 closed enhancement (fixed)
Update to IPython 3.0
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  packages: standard  Keywords:  
Cc:  fbissey, jason  Merged in:  
Authors:  Volker Braun  Reviewers:  R. Andrew Ohana 
Report Upstream:  N/A  Work issues:  
Branch:  e070dd1 (Commits, GitHub, GitLab)  Commit:  e070dd191bb189b83bae5a2a5c12bf4d70981040 
Dependencies:  #17234, #17833, #17288, #17897  Stopgaps: 
Description (last modified by )
Upstream tarball: https://pypi.python.org/packages/source/i/ipython/ipython3.0.0.tar.gz
Change History (28)
comment:1 Changed 6 years ago by
 Component changed from PLEASE CHANGE to packages: standard
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 6 years ago by
 Dependencies set to #17833
comment:3 Changed 6 years ago by
 Branch set to u/vbraun/update_to_ipython_3_0
comment:4 Changed 6 years ago by
 Commit set to a95ad5f275eb6b564687513db453a8ed694ce8aa
comment:5 Changed 6 years ago by
 Dependencies changed from #17833 to #17234, #17833
comment:6 Changed 6 years ago by
 Description modified (diff)
comment:7 Changed 6 years ago by
 Description modified (diff)
comment:8 Changed 6 years ago by
 Commit changed from a95ad5f275eb6b564687513db453a8ed694ce8aa to f11c447e901df3c2931fa9012acc8885ebf42964
Branch pushed to git repo; I updated commit sha1. New commits:
f11c447  Update to IPython 3.0.0

comment:9 Changed 6 years ago by
 Cc fbissey added
 Status changed from new to needs_review
comment:10 Changed 6 years ago by
 Status changed from needs_review to needs_work
the sage ipython notebook needs some work...
comment:11 Changed 6 years ago by
 Commit changed from f11c447e901df3c2931fa9012acc8885ebf42964 to 706573c97276ce4404a735d56c40136e6105763b
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
cc9a5af  Normalize plot data (like texture opacity) to float

37ae94a  Mark all animations that require ImageMagick as #optional

29853da  fix remaining doctest failures

57469c6  correct file permissions

6c6becd  mark more animation doctess as optional ImageMagick

38c6db0  Fix ascii art in the IPython notebook

7c17bce  Fix documentation build

fcbc588  fix the last missing optional ImageMagick

5eb9bc7  Merge #17234: Rich output and the IPython Notebook

706573c  Merge in Sage 6.6.beta2

comment:12 Changed 6 years ago by
 Dependencies changed from #17234, #17833 to #17234, #17833, #17288
comment:13 Changed 6 years ago by
 Commit changed from 706573c97276ce4404a735d56c40136e6105763b to 10c8d5d0ec2f287f957d8bed9977fd734b9a612b
Branch pushed to git repo; I updated commit sha1. New commits:
e8ef55d  #17288 : mathjax spkg

8f18d36  #17288 strip mathjax down from 175M to <10M.

0443d99  #17288 make mathjax standard and a dependency of ipython

3e64ff8  #17288 remove the maintainer info from SPKG.txt

2da5a74  #17288 add mathjax to COPYING.txt

18345c7  #17288 do not test when removing $SAGE_SHARE/mathjax directory

ca645c7  smaller tarball, update to v2.5

8f46bc7  Merge #17288: MathJax spkg for ipython notebook

10c8d5d  Use the new IPython kernel stuff for Sage

comment:14 Changed 6 years ago by
 Commit changed from 10c8d5d0ec2f287f957d8bed9977fd734b9a612b to 0dfff38dc1cd3b45c80d8ce104f775274e6d70cb
Branch pushed to git repo; I updated commit sha1. New commits:
0dfff38  delete the old ipython notebook templates

comment:15 Changed 6 years ago by
comment:16 Changed 6 years ago by
#17234 also works with IPython 2.x, but this ticket depends on it.
comment:17 Changed 6 years ago by
 Commit changed from 0dfff38dc1cd3b45c80d8ce104f775274e6d70cb to e14c533041705465bbfd2b8bcb6587165d4acd9e
Branch pushed to git repo; I updated commit sha1. New commits:
e14c533  Use local docs, icon

comment:18 Changed 6 years ago by
 Cc jason added
 Status changed from needs_work to needs_review
This works now, IMHO it is at least as good as the old one ;)
comment:19 Changed 6 years ago by
 Dependencies changed from #17234, #17833, #17288 to #17234, #17833, #17288, #17897
comment:20 Changed 6 years ago by
 Commit changed from e14c533041705465bbfd2b8bcb6587165d4acd9e to 284fd72c05a4366e0d36afae56fe65605cf71c0e
comment:21 Changed 6 years ago by
 Commit changed from 284fd72c05a4366e0d36afae56fe65605cf71c0e to af760e2af89db267ed07d6df6829d7347cbc04e8
Branch pushed to git repo; I updated commit sha1. New commits:
af760e2  Merge in Sage 6.6.beta3

comment:22 Changed 6 years ago by
 Commit changed from af760e2af89db267ed07d6df6829d7347cbc04e8 to b1f248d3888bec0314c4c430006d40fee37c6bce
Branch pushed to git repo; I updated commit sha1. New commits:
b1f248d  Complete documentation

comment:23 Changed 6 years ago by
 Reviewers set to R. Andrew Ohana
 Status changed from needs_review to needs_work
After clearing out DOT_SAGE
, I get this if I try to start up the notebook:
Traceback (most recent call last): File "/Users/ohanar/code/sage/src/bin/sagenotebook", line 192, in <module> launcher(unknown) File "/Users/ohanar/code/sage/src/bin/sagenotebook", line 79, in __init__ SageKernelSpec.update() File "/Users/ohanar/code/sage/local/lib/python2.7/sitepackages/sage/repl/ipython_kernel/install.py", line 218, in update instance.use_local_mathjax() File "/Users/ohanar/code/sage/local/lib/python2.7/sitepackages/sage/repl/ipython_kernel/install.py", line 100, in use_local_mathjax self.symlink(src, dst) File "/Users/ohanar/code/sage/local/lib/python2.7/sitepackages/sage/repl/ipython_kernel/install.py", line 81, in symlink os.symlink(src, dst) OSError: [Errno 2] No such file or directory
It looks like you are trying to symlink into a directory that hasn't yet been created. Probably just need to add a mkdir p
type thing in there.
comment:24 Changed 6 years ago by
 Commit changed from b1f248d3888bec0314c4c430006d40fee37c6bce to e070dd191bb189b83bae5a2a5c12bf4d70981040
Branch pushed to git repo; I updated commit sha1. New commits:
e070dd1  create parent directories first

comment:25 Changed 6 years ago by
Good point, fixed.
comment:26 Changed 6 years ago by
 Status changed from needs_work to positive_review
Is there any reason why you didn't set this back to needs review? Everything looks good to me.
comment:27 Changed 6 years ago by
sorry, forgot!
comment:28 Changed 6 years ago by
 Branch changed from u/vbraun/update_to_ipython_3_0 to e070dd191bb189b83bae5a2a5c12bf4d70981040
 Resolution set to fixed
 Status changed from positive_review to closed
All doctests pass with IPython 3.0.0rc1 but the IPython notebook now depends on the newer tornado
New commits:
Rich output framework
More documentation
Fix Andrews comments
Rename Lightwave > Wavefront obj
Fix saving 3d preview image without java
Rename mathjax > latex in rich output types
use the plot3d viewer keyword
Merge #17234: Rich output and the IPython Notebook
Update ipython to 3.0.0rc1
Restore old behavior of get_test_shell().run_cell