Opened 6 years ago

Closed 6 years ago

#17826 closed enhancement (fixed)

Update to IPython 3.0

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.6
Component: packages: standard Keywords:
Cc: fbissey, jason Merged in:
Authors: Volker Braun Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: e070dd1 (Commits, GitHub, GitLab) Commit: e070dd191bb189b83bae5a2a5c12bf4d70981040
Dependencies: #17234, #17833, #17288, #17897 Stopgaps:

Status badges

Change History (28)

comment:1 Changed 6 years ago by vbraun

  • Component changed from PLEASE CHANGE to packages: standard
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 6 years ago by vbraun

  • Dependencies set to #17833

comment:3 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/update_to_ipython_3_0

comment:4 Changed 6 years ago by vbraun

  • Commit set to a95ad5f275eb6b564687513db453a8ed694ce8aa

All doctests pass with IPython 3.0.0rc1 but the IPython notebook now depends on the newer tornado


New commits:

7747261Rich output framework
7dc42d9More documentation
2d915f0Fix Andrews comments
be577ffRename Lightwave -> Wavefront obj
af73513Fix saving 3d preview image without java
f5b31e4Rename mathjax -> latex in rich output types
82b4bc1use the plot3d viewer keyword
b1ee9ecMerge #17234: Rich output and the IPython Notebook
c09d7b0Update ipython to 3.0.0rc1
a95ad5fRestore old behavior of get_test_shell().run_cell

comment:5 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Dependencies changed from #17833 to #17234, #17833

comment:6 Changed 6 years ago by vbraun

  • Description modified (diff)

comment:7 Changed 6 years ago by vbraun

  • Description modified (diff)

comment:8 Changed 6 years ago by git

  • Commit changed from a95ad5f275eb6b564687513db453a8ed694ce8aa to f11c447e901df3c2931fa9012acc8885ebf42964

Branch pushed to git repo; I updated commit sha1. New commits:

f11c447Update to IPython 3.0.0

comment:9 Changed 6 years ago by vbraun

  • Cc fbissey added
  • Status changed from new to needs_review

comment:10 Changed 6 years ago by vbraun

  • Status changed from needs_review to needs_work

the sage ipython notebook needs some work...

comment:11 Changed 6 years ago by git

  • Commit changed from f11c447e901df3c2931fa9012acc8885ebf42964 to 706573c97276ce4404a735d56c40136e6105763b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

cc9a5afNormalize plot data (like texture opacity) to float
37ae94aMark all animations that require ImageMagick as #optional
29853dafix remaining doctest failures
57469c6correct file permissions
6c6becdmark more animation doctess as optional ImageMagick
38c6db0Fix ascii art in the IPython notebook
7c17bceFix documentation build
fcbc588fix the last missing optional ImageMagick
5eb9bc7Merge #17234: Rich output and the IPython Notebook
706573cMerge in Sage 6.6.beta2

comment:12 Changed 6 years ago by vbraun

  • Dependencies changed from #17234, #17833 to #17234, #17833, #17288

comment:13 Changed 6 years ago by git

  • Commit changed from 706573c97276ce4404a735d56c40136e6105763b to 10c8d5d0ec2f287f957d8bed9977fd734b9a612b

Branch pushed to git repo; I updated commit sha1. New commits:

e8ef55d#17288 : mathjax spkg
8f18d36#17288 strip mathjax down from 175M to <10M.
0443d99#17288 make mathjax standard and a dependency of ipython
3e64ff8#17288 remove the maintainer info from SPKG.txt
2da5a74#17288 add mathjax to COPYING.txt
18345c7#17288 do not test when removing $SAGE_SHARE/mathjax directory
ca645c7smaller tarball, update to v2.5
8f46bc7Merge #17288: MathJax spkg for ipython notebook
10c8d5dUse the new IPython kernel stuff for Sage

comment:14 Changed 6 years ago by git

  • Commit changed from 10c8d5d0ec2f287f957d8bed9977fd734b9a612b to 0dfff38dc1cd3b45c80d8ce104f775274e6d70cb

Branch pushed to git repo; I updated commit sha1. New commits:

0dfff38delete the old ipython notebook templates

comment:15 Changed 6 years ago by fbissey

Ok. Reviewing mathjax first is the low hanging fruit. Are #17234 and this ticket mutually dependent or could #17234 go in without this one?

6.6.beta2 has a lot of ticket that will require a revision of sage-on-gentoo patches, that will go first before I review stuff that is non-trivial.

comment:16 Changed 6 years ago by vbraun

#17234 also works with IPython 2.x, but this ticket depends on it.

comment:17 Changed 6 years ago by git

  • Commit changed from 0dfff38dc1cd3b45c80d8ce104f775274e6d70cb to e14c533041705465bbfd2b8bcb6587165d4acd9e

Branch pushed to git repo; I updated commit sha1. New commits:

e14c533Use local docs, icon

comment:18 Changed 6 years ago by vbraun

  • Cc jason added
  • Status changed from needs_work to needs_review

This works now, IMHO it is at least as good as the old one ;-)

comment:19 Changed 6 years ago by vbraun

  • Dependencies changed from #17234, #17833, #17288 to #17234, #17833, #17288, #17897

comment:20 Changed 6 years ago by git

  • Commit changed from e14c533041705465bbfd2b8bcb6587165d4acd9e to 284fd72c05a4366e0d36afae56fe65605cf71c0e

Branch pushed to git repo; I updated commit sha1. New commits:

4748c26Merge #17234: Rich output and the IPython Notebook
284fd72Merge Trac #17897: Jsonschema package

comment:21 Changed 6 years ago by git

  • Commit changed from 284fd72c05a4366e0d36afae56fe65605cf71c0e to af760e2af89db267ed07d6df6829d7347cbc04e8

Branch pushed to git repo; I updated commit sha1. New commits:

af760e2Merge in Sage 6.6.beta3

comment:22 Changed 6 years ago by git

  • Commit changed from af760e2af89db267ed07d6df6829d7347cbc04e8 to b1f248d3888bec0314c4c430006d40fee37c6bce

Branch pushed to git repo; I updated commit sha1. New commits:

b1f248dComplete documentation

comment:23 Changed 6 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to needs_work

After clearing out DOT_SAGE, I get this if I try to start up the notebook:

Traceback (most recent call last):
  File "/Users/ohanar/code/sage/src/bin/sage-notebook", line 192, in <module>
    launcher(unknown)
  File "/Users/ohanar/code/sage/src/bin/sage-notebook", line 79, in __init__
    SageKernelSpec.update()
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 218, in update
    instance.use_local_mathjax()
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 100, in use_local_mathjax
    self.symlink(src, dst)
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 81, in symlink
    os.symlink(src, dst)
OSError: [Errno 2] No such file or directory

It looks like you are trying to symlink into a directory that hasn't yet been created. Probably just need to add a mkdir -p type thing in there.

comment:24 Changed 6 years ago by git

  • Commit changed from b1f248d3888bec0314c4c430006d40fee37c6bce to e070dd191bb189b83bae5a2a5c12bf4d70981040

Branch pushed to git repo; I updated commit sha1. New commits:

e070dd1create parent directories first

comment:25 Changed 6 years ago by vbraun

Good point, fixed.

comment:26 Changed 6 years ago by ohanar

  • Status changed from needs_work to positive_review

Is there any reason why you didn't set this back to needs review? Everything looks good to me.

comment:27 Changed 6 years ago by vbraun

sorry, forgot!

comment:28 Changed 6 years ago by vbraun

  • Branch changed from u/vbraun/update_to_ipython_3_0 to e070dd191bb189b83bae5a2a5c12bf4d70981040
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.