Opened 7 years ago

Closed 7 years ago

#17823 closed enhancement (fixed)

Three.js optional package

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.6
Component: packages: optional Keywords:
Cc: jason, kcrisman, novoselt, fbissey Merged in:
Authors: Volker Braun Reviewers: François Bissey, Andrey Novoseltsev
Report Upstream: N/A Work issues: header typo
Branch: b088789 (Commits, GitHub, GitLab) Commit: b088789862e9c044e4cc6a6130a1bf4351f7f281
Dependencies: Stopgaps:

Status badges

Change History (13)

comment:1 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/three_js_optional_package

comment:2 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 90df275eea553fa5cf23b7989d2b12d2c0c18f14
  • Component changed from PLEASE CHANGE to packages: optional
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

90df275Initial package

comment:3 Changed 7 years ago by vbraun

  • Cc jason kcrisman novoselt added

comment:4 Changed 7 years ago by jason

A lot of the important files are in the examples/js directory, for example, the Controls that we use for mouse interaction are in https://github.com/mrdoob/three.js/tree/master/examples/js/controls. Device detection is in https://github.com/mrdoob/three.js/blob/master/examples/js/Detector.js. Perhaps we can save just the examples/js folder and delete everything else.

comment:5 Changed 7 years ago by jason

Actually, what I typically use is just the build/three.min.js, the OrbitControls? from examples/js/controls, and the Detector.js from examples/js/Detector.js.

comment:6 Changed 7 years ago by git

  • Commit changed from 90df275eea553fa5cf23b7989d2b12d2c0c18f14 to 7d3a46f508c992e6b0c4b5b406ce3eaea2326f01

Branch pushed to git repo; I updated commit sha1. New commits:

7d3a46fkeep the examples/js directory

comment:7 Changed 7 years ago by vbraun

The wavefront obj loader will surely be useful, too. No need to go too barebones, just want to avoid 200 of megabytes of samples.

comment:8 Changed 7 years ago by vbraun

  • Cc fbissey added

comment:9 Changed 7 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

I don't see the harm in getting that in. No apparent hook anywhere for it yet either.

comment:10 Changed 7 years ago by novoselt

  • Status changed from positive_review to needs_work
  • Work issues set to header typo

SPKG.txt starts with = MathJax =...

comment:11 Changed 7 years ago by git

  • Commit changed from 7d3a46f508c992e6b0c4b5b406ce3eaea2326f01 to b088789862e9c044e4cc6a6130a1bf4351f7f281

Branch pushed to git repo; I updated commit sha1. New commits:

b088789fix SPKG.txt title

comment:12 Changed 7 years ago by vbraun

  • Reviewers changed from François Bissey to François Bissey, Andrey Novoseltsev
  • Status changed from needs_work to positive_review

Thanks, fixed.

comment:13 Changed 7 years ago by vbraun

  • Branch changed from u/vbraun/three_js_optional_package to b088789862e9c044e4cc6a6130a1bf4351f7f281
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.