Opened 8 years ago

Closed 8 years ago

#17809 closed enhancement (fixed)

RealBall: Document input aliasing

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.6
Component: numerical Keywords: arb, RealBall
Cc: mmezzarobba, fredrik.johansson Merged in:
Authors: Clemens Heuberger Reviewers: Fredrik Johansson, Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 178f31e (Commits, GitHub, GitLab) Commit: 178f31e1c51115e2c40d4f297ec0cee21687f9b0
Dependencies: #17194 Stopgaps:

Status badges

Description

Add a warning that identical balls are assumed to represent the same number.

Change History (7)

comment:1 Changed 8 years ago by cheuberg

Branch: u/cheuberg/rings/real_arb_doc

comment:2 Changed 8 years ago by cheuberg

Commit: a445cf9b4c2c5417aa3ddb7a1180a564f2648a2b
Status: newneeds_review

As discussed in #17194, input aliasing should be documented.


Last 10 new commits:

aa39c10#17194 RealBall: abstract away access to parent precision
d3e3998#17194 RBF: add a precision() method
ce51f81#17194 RBF: some more is_foo() and similar methods
1d92acfTrac #17194: remove fmpr.pxd (partial revert of dd8933a)
5e41fcbTrac #17194: remove imports of fmpr
4e7ec46Trac #17194: is_zero, is_nonzero, is_exact
9e26152Trac #17194: Implement comparisons
1196b57Trac #17194: Fix RealBallField._an_element_
195a6eeTrac #17194: Fix two broken references
a445cf9Trac #17809: Document input aliasing

comment:3 Changed 8 years ago by fredrik.johansson

Is it obvious that "identical real balls" means the same Sage object, not different objects with identical values?

I guess the example should be z = x * x, not z = x^2, as the latter would be correct regardless.

comment:4 Changed 8 years ago by git

Commit: a445cf9b4c2c5417aa3ddb7a1180a564f2648a2b178f31e1c51115e2c40d4f297ec0cee21687f9b0

Branch pushed to git repo; I updated commit sha1. New commits:

178f31eTrac #17809: x*x instead of x^2; mention RealBall objects

comment:5 in reply to:  3 Changed 8 years ago by cheuberg

Replying to fredrik.johansson:

Is it obvious that "identical real balls" means the same Sage object, not different objects with identical values?

I hope that it is clearer now.

I guess the example should be z = x * x, not z = x^2, as the latter would be correct regardless.

Of course, thank you, fixed.

comment:6 Changed 8 years ago by mmezzarobba

Reviewers: Fredrik Johansson, Marc Mezzarobba
Status: needs_reviewpositive_review

comment:7 Changed 8 years ago by vbraun

Branch: u/cheuberg/rings/real_arb_doc178f31e1c51115e2c40d4f297ec0cee21687f9b0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.