Opened 6 years ago

Closed 6 years ago

#17800 closed enhancement (fixed)

Replace PY_TYPE_CHECK and IS_INSTANCE by isinstance

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: 4fcee82 (Commits, GitHub, GitLab) Commit: 4fcee8214e0136d5c02ac7e528f65925740d4db7
Dependencies: #17740 Stopgaps:

Status badges

Description


Change History (10)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17800
  • Created changed from 02/18/15 09:23:24 to 02/18/15 09:23:24
  • Modified changed from 02/18/15 09:23:24 to 02/18/15 09:23:24

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 73da7b68a9f51970c922e7a7eb378fce5b8e405d
  • Status changed from new to needs_review

New commits:

​9408bbfReplace PY_TYPE_CHECK and IS_INSTANCE by isinstance
​33d4186Replace bool(isinstance()) by isinstance()
​3b92c10Fix PolynomialSequence check
​73da7b6Fix doctest

comment:3 Changed 6 years ago by git

  • Commit changed from 73da7b68a9f51970c922e7a7eb378fce5b8e405d to 314185c8baf91c2207723476d7f2e3fa131547b9

Branch pushed to git repo; I updated commit sha1. New commits:

​314185cMerge remote-tracking branch 'origin/develop' into t/17800/ticket/17800

comment:4 Changed 6 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Conflict in src/sage/structure/coerce.pyx, probably #17740

comment:6 Changed 6 years ago by jdemeyer

Am I allowed to say "merge with -X ours"?

comment:7 Changed 6 years ago by git

  • Commit changed from 314185c8baf91c2207723476d7f2e3fa131547b9 to 4fcee8214e0136d5c02ac7e528f65925740d4db7

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​7744207Better behavior for polynomial division.
​1e88c72Another polynomial division action test.
​a60134ctrac #17740: review 1 (documentation)
​728811dtrac #17740: review 2 (clean Errors)
​96c1a03trac #17740: review 3 (less in try/except block)
​2cb51c0Re-introduce action of fraction field as fallback for division action.
​bff474bBetter _pseudo_fraction_field default implementation.
​9c970aetrac #17740: merge sage-6.6.beta1
​2075e2etrac #17740: avoid parent deaths
​4fcee82Merge commit '2075e2e' into t/17800/ticket/17800

comment:8 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to positive_review

comment:9 Changed 6 years ago by jdemeyer

  • Dependencies set to #17740

comment:10 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17800 to 4fcee8214e0136d5c02ac7e528f65925740d4db7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.