Opened 7 years ago
Closed 7 years ago
#17800 closed enhancement (fixed)
Replace PY_TYPE_CHECK and IS_INSTANCE by isinstance
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  cython  Keywords:  
Cc:  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  R. Andrew Ohana 
Report Upstream:  N/A  Work issues:  
Branch:  4fcee82 (Commits, GitHub, GitLab)  Commit:  4fcee8214e0136d5c02ac7e528f65925740d4db7 
Dependencies:  #17740  Stopgaps: 
Description
Change History (10)
comment:1 Changed 7 years ago by
 Branch set to u/jdemeyer/ticket/17800
 Created changed from 02/18/15 09:23:24 to 02/18/15 09:23:24
 Modified changed from 02/18/15 09:23:24 to 02/18/15 09:23:24
comment:2 Changed 7 years ago by
 Commit set to 73da7b68a9f51970c922e7a7eb378fce5b8e405d
 Status changed from new to needs_review
comment:3 Changed 7 years ago by
 Commit changed from 73da7b68a9f51970c922e7a7eb378fce5b8e405d to 314185c8baf91c2207723476d7f2e3fa131547b9
Branch pushed to git repo; I updated commit sha1. New commits:
314185c  Merge remotetracking branch 'origin/develop' into t/17800/ticket/17800

comment:4 Changed 7 years ago by
 Reviewers set to R. Andrew Ohana
 Status changed from needs_review to positive_review
Looks good to me.
comment:5 Changed 7 years ago by
 Status changed from positive_review to needs_work
Conflict in src/sage/structure/coerce.pyx, probably #17740
comment:6 Changed 7 years ago by
Am I allowed to say "merge with X ours
"?
comment:7 Changed 7 years ago by
 Commit changed from 314185c8baf91c2207723476d7f2e3fa131547b9 to 4fcee8214e0136d5c02ac7e528f65925740d4db7
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7744207  Better behavior for polynomial division.

1e88c72  Another polynomial division action test.

a60134c  trac #17740: review 1 (documentation)

728811d  trac #17740: review 2 (clean Errors)

96c1a03  trac #17740: review 3 (less in try/except block)

2cb51c0  Reintroduce action of fraction field as fallback for division action.

bff474b  Better _pseudo_fraction_field default implementation.

9c970ae  trac #17740: merge sage6.6.beta1

2075e2e  trac #17740: avoid parent deaths

4fcee82  Merge commit '2075e2e' into t/17800/ticket/17800

comment:8 Changed 7 years ago by
 Status changed from needs_work to positive_review
comment:9 Changed 7 years ago by
 Dependencies set to #17740
comment:10 Changed 7 years ago by
 Branch changed from u/jdemeyer/ticket/17800 to 4fcee8214e0136d5c02ac7e528f65925740d4db7
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Replace PY_TYPE_CHECK and IS_INSTANCE by isinstance
Replace bool(isinstance()) by isinstance()
Fix PolynomialSequence check
Fix doctest