Opened 5 years ago

Closed 5 years ago

#17799 closed defect (fixed)

refactor real_set.RealInterval

Reported by: rws Owned by:
Priority: minor Milestone: sage-6.6
Component: calculus Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ef6f40b (Commits) Commit: ef6f40b30b19e46eacad816490b68479b3011891
Dependencies: Stopgaps:

Description (last modified by rws)

The class sage.sets.real_set.RealInterval is badly named. Despite being "private" it can be easily confused in the documentation with RealInterval=sage.rings.real_mpfi.RealIntervalFieldElement. The ticket will rename real_set.py:RealInterval.

Change History (10)

comment:1 Changed 5 years ago by rws

  • Branch set to u/rws/refactor_real_set_realinterval

comment:2 Changed 5 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 566688bc3e828d84cd258467442d0604c3bae3ce
  • Status changed from new to needs_review

New commits:

566688b17799: refactor real_set.py:RealInterval

comment:3 Changed 5 years ago by tscrim

You missed this on in the docstring of __init__:

You are not supposed to create :class:`RealInterval` objects

Also could you also move the docstring (except the example block) up to the class level? Thanks.

comment:4 Changed 5 years ago by rws

You haven't read the description: The reason the latter is needed is, although the class is private, its instances can be exposed and users may at least want to create new RealSets? from them.

comment:5 Changed 5 years ago by git

  • Commit changed from 566688bc3e828d84cd258467442d0604c3bae3ce to e19c7954d970f3fd9ca54fc95c7010bd3c200179

Branch pushed to git repo; I updated commit sha1. New commits:

3388b08Merge branch 'develop' into t/17799/refactor_real_set_realinterval
e19c79517799: cosmetics

comment:6 Changed 5 years ago by rws

  • Description modified (diff)

comment:7 Changed 5 years ago by rws

  • Description modified (diff)
  • Priority changed from major to minor

Okay, it's no longer needed by #14801.

comment:8 Changed 5 years ago by tscrim

  • Branch changed from u/rws/refactor_real_set_realinterval to public/refactor_real_set_realinterval-17799
  • Commit changed from e19c7954d970f3fd9ca54fc95c7010bd3c200179 to ef6f40b30b19e46eacad816490b68479b3011891
  • Reviewers set to Travis Scrimshaw

I made some trivial documentation tweaks. If you're happy them, then positive review.


New commits:

ef6f40bMinor reviewer doc tweaks.

comment:9 Changed 5 years ago by rws

  • Status changed from needs_review to positive_review

Is fine, thanks.

comment:10 Changed 5 years ago by vbraun

  • Branch changed from public/refactor_real_set_realinterval-17799 to ef6f40b30b19e46eacad816490b68479b3011891
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.