Opened 5 years ago

Closed 5 years ago

#17794 closed defect (fixed)

Fix csage build

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: build Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 6650ca7 (Commits) Commit: 6650ca79a28bd96cd66d3dc3b3b917bd91c415e5
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

In build/deps, the csage target doesn't depend on the c_lib sources. This causes make to fail after making certain changes to c_lib, when ./sage -b succeeds.

Change History (6)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17794
  • Created changed from 02/17/15 10:26:07 to 02/17/15 10:26:07
  • Modified changed from 02/17/15 10:26:07 to 02/17/15 10:26:07

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 6650ca79a28bd96cd66d3dc3b3b917bd91c415e5
  • Status changed from new to needs_review

New commits:

6650ca7Add csage dependencies in Makefile

comment:3 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 5 years ago by fbissey

  • Cc fbissey added

comment:5 Changed 5 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks good to me.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17794 to 6650ca79a28bd96cd66d3dc3b3b917bd91c415e5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.