Opened 5 years ago

Closed 5 years ago

#17789 closed enhancement (fixed)

Remove c_lib/src/ZZ_pylong.cpp

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: c_lib Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 91197b4 (Commits) Commit: 91197b40bc6919fe1eacdb894a4478b9f12a24ea
Dependencies: #17881 Stopgaps:

Description

The function ZZ_get_pylong is unused and can be removed.

The function ZZ_set_pylong is moved to src/sage/libs/ntl/ntl_ZZ.pyx

Change History (9)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17789
  • Created changed from 02/16/15 15:04:08 to 02/16/15 15:04:08
  • Modified changed from 02/16/15 15:04:08 to 02/16/15 15:04:08

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 5d11157819c64e5c8d9489fa013de06d921ed915
  • Status changed from new to needs_review

New commits:

​5d11157Remove c_lib/src/ZZ_pylong.cpp

comment:3 Changed 5 years ago by git

  • Commit changed from 5d11157819c64e5c8d9489fa013de06d921ed915 to 9a2432fb943373bf665c8c076cda96b42a136fb4

Branch pushed to git repo; I updated commit sha1. New commits:

​9a2432fMerge tag '6.6.beta2' into t/17789/ticket/17789

comment:4 Changed 5 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

All tests passed.

comment:5 follow-up: Changed 5 years ago by git

  • Commit changed from 9a2432fb943373bf665c8c076cda96b42a136fb4 to 91197b40bc6919fe1eacdb894a4478b9f12a24ea
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​745a3dbRemove declarations for ZZ_get_pylong/ZZ_set_pylong
​145de10Move memory functions to Cython
​91197b4Merge ticket/17881 into ticket/17789

comment:6 in reply to: ↑ 5 Changed 5 years ago by jdemeyer

I added this commit:

​745a3dbRemove declarations for ZZ_get_pylong/ZZ_set_pylong

and merged #17881 to resolve a conflict in SConstruct.

Can you please review?

comment:7 Changed 5 years ago by jdemeyer

  • Dependencies set to #17881

comment:8 Changed 5 years ago by aapitzsch

  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17789 to 91197b40bc6919fe1eacdb894a4478b9f12a24ea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.