Opened 7 years ago
Closed 7 years ago
#17788 closed enhancement (fixed)
PARI: store GEN as mpz/mpq
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.5 |
Component: | c_lib | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | R. Andrew Ohana |
Report Upstream: | N/A | Work issues: | |
Branch: | 8da6fc3 (Commits, GitHub, GitLab) | Commit: | 8da6fc379fff10d046638e659573d40cc59d5b1f |
Dependencies: | Stopgaps: |
Description
Move the two functions which are currently in src/c_lib/src/convert.c
to src/sage/libs/pari/pari_instance.pyx
Change History (7)
comment:1 Changed 7 years ago by
- Branch set to u/jdemeyer/ticket/17788
- Created changed from 02/16/15 12:53:31 to 02/16/15 12:53:31
- Modified changed from 02/16/15 12:53:31 to 02/16/15 12:53:31
comment:2 Changed 7 years ago by
- Commit set to 8da6fc379fff10d046638e659573d40cc59d5b1f
- Status changed from new to needs_review
- Summary changed from PariInterface: store as mpz/mpq to PARI: store GEN as mpz/mpq
comment:3 Changed 7 years ago by
- Reviewers set to R. Andrew Ohana
- Status changed from needs_review to needs_work
In matrix_integer_dense.pyx
there is a use of PY_NEW
that should be replaced with __new__
. Otherwise looks good.
comment:4 Changed 7 years ago by
- Status changed from needs_work to needs_review
No, due to the hacking with tp_new
, for Integer
, PY_NEW(Integer)
is not the same as Integer.__new__(Integer)
.
comment:5 Changed 7 years ago by
In any case, let's leave fixing PY_NEW(Integer)
for a different ticket.
comment:6 Changed 7 years ago by
- Status changed from needs_review to positive_review
Ah, ok. Sounds good then.
comment:7 Changed 7 years ago by
- Branch changed from u/jdemeyer/ticket/17788 to 8da6fc379fff10d046638e659573d40cc59d5b1f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Move conversion PARI->mpz/mpq to pari_instance.pyx