Opened 5 years ago

Closed 3 years ago

#17770 closed enhancement (fixed)

Euler numbers revamp

Reported by: rws Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: symbolics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

  • move euler_number from combinatorics to functions
  • replace pexpect-maxima with maxima-lib implementation
  • make GP/Pari the main version with euler(n)=subst(bernpol(2*n+1), 'x, 1/4)*4^(2*n+1)*(-1)^(n+1)/(2*n+1) (Charles R Greathouse IV)
  • mpmath has fp Euler numbers

Change History (8)

comment:1 follow-up: Changed 5 years ago by jdemeyer

What you're proposing seems like 4 tickets, not 1 ticket...

comment:2 in reply to: ↑ 1 ; follow-up: Changed 5 years ago by rws

Replying to jdemeyer:

What you're proposing seems like 4 tickets, not 1 ticket...

It's not substantially more than any other symbolic function ticket. Not that there is heavy use that would justify several tickets.

comment:3 in reply to: ↑ 2 Changed 5 years ago by jdemeyer

Replying to rws:

It's not substantially more than any other symbolic function ticket. Not that there is heavy use that would justify several tickets.

Neither of this matters. The question is: can the issue be easily and naturally be split up? If the answer to that is yes, it should be done.

I have just seen too often that a ticket does A, B, C and there are issues with C. These issues with C turn out to be much harder than originally thought. Therefore, A and B are never merged or merged with a big delay, even though they could have been merged quickly.

Note: personally I don't care much about this ticket, so if a reviewer doesn't mind, then it's obviously not a problem.

comment:4 Changed 5 years ago by rws

  • Milestone changed from sage-6.5 to sage-wishlist

comment:5 Changed 3 years ago by rws

  • Milestone changed from sage-wishlist to sage-duplicate/invalid/wontfix

See #20763

comment:6 Changed 3 years ago by rws

  • Status changed from new to needs_review

comment:7 Changed 3 years ago by rws

  • Status changed from needs_review to positive_review

comment:8 Changed 3 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.