Opened 4 years ago
Closed 4 years ago
#17762 closed enhancement (fixed)
Connected component for a rational preperiodic point
Reported by:  gjorgenson  Owned by:  

Priority:  minor  Milestone:  sage6.6 
Component:  algebraic geometry  Keywords:  
Cc:  bhutz  Merged in:  
Authors:  Grayson Jorgenson  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  e710a42 (Commits)  Commit:  e710a42412cd7bb7891cf49fefafc49f6c5ff2ca 
Dependencies:  Stopgaps: 
Description
Implement function to compute the connected component of a rational preperiodic point of a projective morphism. User should be able to specify a maximum distance to branch out from the preperiodic point.
Change History (8)
comment:1 Changed 4 years ago by
 Branch set to u/gjorgenson/ticket/17762
 Created changed from 02/10/15 19:24:43 to 02/10/15 19:24:43
 Modified changed from 02/10/15 19:24:43 to 02/10/15 19:24:43
comment:2 Changed 4 years ago by
 Commit set to a2068bd1be70e792fe7fddba3a2fe9755957418f
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Milestone changed from sage6.5 to sage6.6
comment:4 Changed 4 years ago by
 Reviewers set to Ben Hutz
 Status changed from needs_review to needs_work
The functionality is working fine. There are a couple little things to fix
 the Input and Output docs strings do not format correctly
 adjust the doc string to reflect nonpreperiodic points such your second doc example
 add a comment or two more in the code to help a reader follow along
 the while True/break perhaps should be done another way.
comment:5 Changed 4 years ago by
 Commit changed from a2068bd1be70e792fe7fddba3a2fe9755957418f to e710a42412cd7bb7891cf49fefafc49f6c5ff2ca
Branch pushed to git repo; I updated commit sha1. New commits:
e710a42  17762: Fixed documentation and minor issues

comment:6 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:7 Changed 4 years ago by
 Status changed from needs_review to positive_review
This looks good now.
comment:8 Changed 4 years ago by
 Branch changed from u/gjorgenson/ticket/17762 to e710a42412cd7bb7891cf49fefafc49f6c5ff2ca
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
17762: Implemented function to compute the connected component of a rational preperiodic point