Opened 4 years ago

Closed 4 years ago

#17750 closed defect (fixed)

Random failure in sage.graphs.genus.simple_connected_genus_backtracker.__dealloc__

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.5
Component: graph theory Keywords: random_fail
Cc: ncohen Merged in:
Authors: Nathann Cohen Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 34e9d38 (Commits) Commit: 34e9d383550f31889ccbdddae6e93928bf66b271
Dependencies: Stopgaps:

Description

This sometimes fails (to be expected, not a safe way to test for memory leaks):

sage -t --long src/sage/graphs/genus.pyx
**********************************************************************
File "src/sage/graphs/genus.pyx", line 136, in sage.graphs.genus.simple_connected_genus_backtracker.__dealloc__
Failed example:
    get_memory_usage(t) <= 0.0
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of  10 in sage.graphs.genus.simple_connected_genus_backtracker.__dealloc__
    [61 tests, 1 failure, 21.14 s]

Change History (6)

comment:1 Changed 4 years ago by ncohen

just a comment: don't expect a 10 minutes fix for this one, I have no idea how that code works.

...

Oh. Just a stupid doctest. I see.

Last edited 4 years ago by ncohen (previous) (diff)

comment:2 Changed 4 years ago by ncohen

What do you think should be done with this doctest ? Simply removed ? I don't see how I could make it work.

Nathann

comment:3 Changed 4 years ago by vbraun

still happens.

Should be removed if it can't be made to work reliably.

comment:4 Changed 4 years ago by ncohen

  • Authors set to Nathann Cohen
  • Branch set to public/17750
  • Commit set to 34e9d383550f31889ccbdddae6e93928bf66b271
  • Status changed from new to needs_review

New commits:

34e9d38trac #17750: Remove unreliable doctest

comment:5 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm

comment:6 Changed 4 years ago by vbraun

  • Branch changed from public/17750 to 34e9d383550f31889ccbdddae6e93928bf66b271
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.