Opened 4 years ago

Closed 4 years ago

#17724 closed enhancement (fixed)

Rename PowerSeries.reversion() in PowerSeries.reverse()

Reported by: bruno Owned by:
Priority: major Milestone: sage-6.5
Component: commutative algebra Keywords: reverse, series
Cc: Merged in:
Authors: Bruno Grenet Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 05bbf4a (Commits) Commit: 05bbf4ad70765e6a1a8cdb3c3e6930231f2fbec8
Dependencies: Stopgaps:

Description

The method PowerSeries.reversion(self) returns the reverse power series of self. Following the apparent naming convention, I propose to rename it PowerSeries.reverse(self).

It is more consistent with other method such as (for PowerSeries): derivative() (not derivation) or truncate() (not truncation).

Change History (4)

comment:1 Changed 4 years ago by bruno

  • Branch set to u/bruno/rename_powerseries_reversion___in_powerseries_reverse__

comment:2 Changed 4 years ago by bruno

  • Commit set to 05bbf4ad70765e6a1a8cdb3c3e6930231f2fbec8
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

05bbf4aReplace reversion by reverse

comment:3 Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Looks fine. Thanks.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/bruno/rename_powerseries_reversion___in_powerseries_reverse__ to 05bbf4ad70765e6a1a8cdb3c3e6930231f2fbec8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.