Opened 5 years ago

Closed 5 years ago

#17719 closed defect (fixed)

Fix "match bug with echo"

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: interfaces Keywords:
Cc: vbraun Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4014b69 (Commits) Commit: 4014b69fc825a96a6781b95ca16e7d228c713cfe
Dependencies: Stopgaps:

Description

#15631 added the following lines to src/sage/interfaces/expect.py:

                    if out == '':   # match bug with echo
                        out = line

It seems these were added to be compatible with an existing bug.

Instead, fix that bug!

Change History (9)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17719
  • Created changed from 02/03/15 13:01:18 to 02/03/15 13:01:18
  • Modified changed from 02/03/15 13:01:18 to 02/03/15 13:01:18

comment:2 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 278e3a1813a2b5d211b3fc56dd4be60ebb64f328
  • Status changed from new to needs_review

New commits:

278e3a1Fix match bug with echo

comment:3 Changed 5 years ago by jdemeyer

  • Cc vbraun added

comment:4 Changed 5 years ago by chapoton

  • Branch changed from u/jdemeyer/ticket/17719 to public/ticket/17719
  • Commit changed from 278e3a1813a2b5d211b3fc56dd4be60ebb64f328 to 4014b69fc825a96a6781b95ca16e7d228c713cfe

Looks good to me.

I have just made a small commit, adding another trac role, removing an unused variable and a duplicated import, all of that in the singular interface. If you agree, you can set this to positive review.


New commits:

ff34589Merge branch 'u/jdemeyer/ticket/17719' into 6.6.b0
4014b69trac #17719 a few details in doc of singular interface

comment:5 Changed 5 years ago by jdemeyer

  • Reviewers set to Frédéric Chapoton

comment:6 Changed 5 years ago by chapoton

Please set to positive review, if you want

comment:7 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 5 years ago by chapoton

  • Milestone changed from sage-6.5 to sage-6.6

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/ticket/17719 to 4014b69fc825a96a6781b95ca16e7d228c713cfe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.