Opened 6 years ago

Closed 6 years ago

#17699 closed enhancement (wontfix)

Remove bashisms in src/bin shell scripts

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: scripts Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

It seems to increase portability, see e.g. #17513.

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-6.5 to sage-duplicate/invalid/wontfix
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

We have been assuming bash for a very long time. Removing bashisms would require replacing those scripts by more complicated code, giving more chances of breakage.

And if you stop assuming bash as shell, you have to test that things works on all shells. Again giving more chances of breakage.

Proposal: close as "wontfix".

comment:2 Changed 6 years ago by aapitzsch

As pointed out by Volker in ticket:15642#comment:13 and [1]

Python is a requirement. Sooner or later Sage won't build without Python

so the shell scripts could be replaced by python scripts as it is done in #15642.

[1] https://groups.google.com/forum/#!topic/sage-devel/akds04MBQYg

comment:3 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:4 Changed 6 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.