Opened 8 years ago

Closed 6 years ago

#17680 closed defect (fixed)

bug in Singulars factorize()

Reported by: jakobkroeker Owned by:
Priority: minor Milestone: sage-7.6
Component: packages: standard Keywords: Singular
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: 3ade8eb (Commits, GitHub, GitLab) Commit: 3ade8eb4ec57a7a7c509980df8d62a417fa872ec
Dependencies: Stopgaps: #17681

Status badges

Description

failing example: 

sage: R.<a,r,v,n,g,f,h,o>=QQ[]
sage: f = 248301045*a^2*r^10*n^2*o^10+570807000*a^2*r^9*n*o^9-137945025*a^2*r^8*n^2*o^8+328050000*a^2*r^8*o^8-253692000*a^2*r^7*n*o^7+30654450*a^2*r^6*n^2*o^6-109350000*a^2*r^6*o^6+42282000*a^2*r^5*n*o^5-3406050*a^2*r^4*n^2*o^4-22457088*a*r^2*v*n^2*o^6+12150000*a^2*r^4*o^4-3132000*a^2*r^3*n*o^3+189225*a^2*r^2*n^2*o^2+2495232*a*v*n^2*o^4-450000*a^2*r^2*o^2+87000*a^2*r*n*o-4205*a^2*n^2;
sage: factors = factor(f); 
sage: len(factors) # 3, expected 4
sage: factor(factors[1][0])
(3*r*o - 1) * (3*r*o + 1)

corresponding upsteam report:

​http://www.singular.uni-kl.de:8002/trac/ticket/659

This bug is fixed in Singular 4.0.1

Change History (8)

comment:1 Changed 8 years ago by jakobkroeker

  • Stopgaps set to #17681

comment:2 Changed 6 years ago by jmantysalo

  • Cc tscrim added
  • Milestone changed from sage-6.5 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Can be closed, as Singular 4 is now part of Sage. Travis, I guess you can confirm.

comment:3 follow-up: Changed 6 years ago by tscrim

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-7.6
  • Report Upstream changed from Fixed upstream, in a later stable release. to Completely fixed; Fix reported upstream
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to needs_work

I think we should add a doctest to confirm and to prevent regressions.

comment:4 in reply to: ↑ 3 Changed 6 years ago by jmantysalo

  • Authors set to Jori Mäntysalo

Replying to tscrim:

I think we should add a doctest to confirm and to prevent regressions.

Good point. I'll do.

comment:5 Changed 6 years ago by jmantysalo

  • Branch set to u/jmantysalo/bug_in_singulars_factorize__

comment:6 Changed 6 years ago by jmantysalo

  • Commit set to 3ade8eb4ec57a7a7c509980df8d62a417fa872ec
  • Status changed from needs_work to needs_review

New commits:

​3ade8ebAdd test for a Singular 3 bug.

comment:7 Changed 6 years ago by chapoton

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, look good

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jmantysalo/bug_in_singulars_factorize__ to 3ade8eb4ec57a7a7c509980df8d62a417fa872ec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.