Opened 6 years ago
Closed 6 years ago
#17672 closed defect (fixed)
Doctest failure in orthogonal_arrays.py
Reported by:  jdemeyer  Owned by:  

Priority:  blocker  Milestone:  sage6.5 
Component:  combinatorics  Keywords:  
Cc:  ncohen  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  cf9d2bb (Commits, GitHub, GitLab)  Commit:  cf9d2bbbb5840628451a6fcaa2251f4c18d3687c 
Dependencies:  Stopgaps: 
Description
sage t src/sage/combinat/designs/orthogonal_arrays.py ********************************************************************** File "src/sage/combinat/designs/orthogonal_arrays.py", line 1191, in sage.combinat.designs.orthogonal_arrays.incomplete_orthogonal_array Failed example: for i in range(10): iOA.extend([[1539*(i+1)+x for x in B] for B in OA9]) Exception raised: Traceback (most recent call last): File "/usr/local/src/sageconfig/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 488, in _run self.compile_and_execute(example, compiler, test.globs) File "/usr/local/src/sageconfig/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 850, in compile_and_execute exec(compiled, globs) File "<doctest sage.combinat.designs.orthogonal_arrays.incomplete_orthogonal_array[27]>", line 2, in <module> iOA.extend([[Integer(153)Integer(9)*(i+Integer(1))+x for x in B] for B in OA9]) NameError: name 'iOA' is not defined ********************************************************************** File "src/sage/combinat/designs/orthogonal_arrays.py", line 1193, in sage.combinat.designs.orthogonal_arrays.incomplete_orthogonal_array Failed example: is_orthogonal_array(iOA,10,153) Exception raised: Traceback (most recent call last): File "/usr/local/src/sageconfig/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 488, in _run self.compile_and_execute(example, compiler, test.globs) File "/usr/local/src/sageconfig/local/lib/python2.7/sitepackages/sage/doctest/forker.py", line 850, in compile_and_execute exec(compiled, globs) File "<doctest sage.combinat.designs.orthogonal_arrays.incomplete_orthogonal_array[28]>", line 1, in <module> is_orthogonal_array(iOA,Integer(10),Integer(153)) NameError: name 'iOA' is not defined **********************************************************************
Change History (7)
comment:1 followup: ↓ 2 Changed 6 years ago by
 Cc ncohen added
comment:2 in reply to: ↑ 1 ; followup: ↓ 6 Changed 6 years ago by
 Branch set to public/17672
 Status changed from new to needs_review
Nathan! ;)
Gladly. But with two final 'n' :P
Nathann
comment:3 Changed 6 years ago by
 Commit set to cf9d2bbbb5840628451a6fcaa2251f4c18d3687c
Branch pushed to git repo; I updated commit sha1. New commits:
cf9d2bb  trac #17672: Doctest failure in orthogonal_arrays.py

comment:4 Changed 6 years ago by
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to positive_review
comment:5 Changed 6 years ago by
Thanks.
We have been found guilty of never running tests without the l
flag.
Nathann
comment:6 in reply to: ↑ 2 Changed 6 years ago by
Replying to ncohen:
Nathan! ;)
Gladly. But with two final 'n'
:P
Nathann
undefined iOA
looked like someone has hit an extra i
in vi, and so I guess Volker was trying to make this clear :)
comment:7 Changed 6 years ago by
 Branch changed from public/17672 to cf9d2bbbb5840628451a6fcaa2251f4c18d3687c
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Nathan! ;)