Opened 6 years ago

Closed 5 years ago

#17668 closed enhancement (fixed)

Replace PY_NEW and PY_NEW_SAME_TYPE by __new__() method

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 47217bc (Commits) Commit: 47217bc771195d933edb8aa1b89614e1219c4a82
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Change this everywhere except for Integer and RealDoubleElement classes, which use a custom hooked tp_new that Cython isn't aware of.

Change History (7)

comment:1 Changed 6 years ago by jdemeyer

  • Dependencies set to #17670

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17668
  • Created changed from 01/25/15 14:19:37 to 01/25/15 14:19:37
  • Modified changed from 01/25/15 16:51:30 to 01/25/15 16:51:30

comment:3 Changed 6 years ago by git

  • Commit set to 47217bc771195d933edb8aa1b89614e1219c4a82

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

47217bcReplace PY_NEW and PY_NEW_SAME_TYPE by Cython code

comment:4 Changed 6 years ago by jdemeyer

  • Dependencies #17670 deleted
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Replace PY_NEW by __new__() method to Replace PY_NEW and PY_NEW_SAME_TYPE by __new__() method

comment:5 Changed 6 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17668 to 47217bc771195d933edb8aa1b89614e1219c4a82
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.