Opened 6 years ago

Closed 6 years ago

#17655 closed enhancement (fixed)

two difference sets

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.5
Component: combinatorial designs Keywords:
Cc: ncohen Merged in:
Authors: Vincent Delecroix Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 39d2f0c (Commits) Commit: 39d2f0cb6e683f2dfa51e5869d2b5afb7109b644
Dependencies: Stopgaps:

Description

It appears that there are two difference sets from http://www.ccrwest.org/diffsets.html that are not yet in Sage... let us have them!

Change History (6)

comment:1 Changed 6 years ago by vdelecroix

  • Branch set to public/17655
  • Commit set to 39d2f0cb6e683f2dfa51e5869d2b5afb7109b644
  • Status changed from new to needs_review
  • Summary changed from two difference set to two difference sets

New commits:

39d2f0ctrac #17655: two difference sets

comment:2 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Thanks to all the checks in the design code, there is nothing to review :-PPP

Nathann

comment:3 Changed 6 years ago by ncohen

(and even the doc is updated automatically...)

comment:4 follow-up: Changed 6 years ago by vdelecroix

Thanks (at least you need to be here and set to positive review).

I guess this is the fastest review from creation to positive review... 3 minutes ;-)

Vincent

comment:5 in reply to: ↑ 4 Changed 6 years ago by ncohen

I guess this is the fastest review from creation to positive review... 3 minutes ;-)

Not sure. You are competing with one-letter typos there.

Nathann

Last edited 6 years ago by ncohen (previous) (diff)

comment:6 Changed 6 years ago by vbraun

  • Branch changed from public/17655 to 39d2f0cb6e683f2dfa51e5869d2b5afb7109b644
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.