Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17654 closed defect (fixed)

Fix more load/save bugs

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 1e8ee98 (Commits, GitHub, GitLab) Commit:
Dependencies: #17460 Stopgaps:

Status badges

Description (last modified by jdemeyer)

  1. Remove all documentation about load filename, it should be load("filename").
  2. src.sage.repl.load calls eval(!) on the filename, deprecate that behaviour.
  3. The optional - internet tests in src/sage/repl/load.py are broken since #17396.
  4. Move loading of Fortran files to src/sage/repl/load.py.

Change History (15)

comment:1 Changed 6 years ago by jdemeyer

  • Dependencies set to #17460

comment:2 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17654
  • Created changed from 01/20/15 10:07:58 to 01/20/15 10:07:58
  • Modified changed from 01/20/15 12:26:26 to 01/20/15 12:26:26

comment:8 Changed 6 years ago by jdemeyer

  • Commit set to 1e8ee98386741e62ba34a0887752900e91090add
  • Status changed from new to needs_review

New commits:

​d12c094Deprecate moved imports from sage.misc.misc
​1e8ee98Fix more load/save bugs

comment:9 follow-up: Changed 6 years ago by mmezzarobba

LGTM, but there appears to be a minor merge conflict with #17533.

comment:10 in reply to: ↑ 9 Changed 6 years ago by jdemeyer

  • Reviewers set to Marc Mezzarobba

Replying to mmezzarobba:

there appears to be a minor merge conflict with #17533.

Fixed now.

comment:11 Changed 6 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

comment:12 Changed 6 years ago by jdemeyer

Thanks!

comment:13 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17654 to 1e8ee98386741e62ba34a0887752900e91090add
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 follow-up: Changed 6 years ago by iandrus

  • Commit 1e8ee98386741e62ba34a0887752900e91090add deleted

I'm seeing the warning when I use

sage: %runfile '/var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage' # loading region... /Users/iandrus/vcs/sage/src/bin/sage-ipython:1: DeprecationWarning?: using unevaluated expressions as argument to load() is dangerous and deprecated See ​http://trac.sagemath.org/17654 for details.

#!/usr/bin/env python

Is that expected? And I should change it to

load('/var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage')

comment:15 in reply to: ↑ 14 Changed 6 years ago by jdemeyer

Remove the quotes: 

sage: %runfile /var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage
Note: See TracTickets for help on using tickets.