Opened 6 years ago
Closed 6 years ago
#17649 closed enhancement (fixed)
Kirkman Triple Systems (end of the construction)
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.5 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix, dimpase  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  005e53e (Commits)  Commit:  005e53e3283b11d0c395b4325b11b1a2c2ab6df2 
Dependencies:  #17612  Stopgaps: 
Description
With this branch, we can build in Sage a resolvable (v,3,1)
BIBD whenever it exists.
Nathann
Change History (15)
comment:1 Changed 6 years ago by
 Branch set to public/17649
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Commit set to 0c48b4822e7133ccf370236f4fc2c3ba81dfca5d
comment:3 Changed 6 years ago by
 Commit changed from 0c48b4822e7133ccf370236f4fc2c3ba81dfca5d to 3250b35558e407c967b8497d3593b2c225b7331d
Branch pushed to git repo; I updated commit sha1. New commits:
3250b35  trac #17649: GDD from TD

comment:4 Changed 6 years ago by
 Commit changed from 3250b35558e407c967b8497d3593b2c225b7331d to 79831523ba0fa8074f055647191ad3c6b49da324
Branch pushed to git repo; I updated commit sha1. New commits:
7983152  doc

comment:5 Changed 6 years ago by
Hello,
Don't you want to group together the PBD constructions? Right now, some are contained in bibd.py
and the others in resolvable_bibd.py
.
Vincent
comment:6 Changed 6 years ago by
I don't have a very strong preference for one or the other. Right now there is no PBD file nor PBD constructor, so we do not care much. Also the point of these constructions is that this specific PBD if somehow equivalent to KTS, so it makes sense to store them together.
Let's keep it like that until we have a real reason to move them together. Like a PBD constructor.
Nathann
comment:7 Changed 6 years ago by
 Branch changed from public/17649 to public/17649bis
 Commit changed from 79831523ba0fa8074f055647191ad3c6b49da324 to f6c2af6ce39ed44e45607647c67ca724ac283e87
Hi Nathann,
I did not feel very well with one line which mixes sorted
, enumerate
and set
. I propose a commit to split them into several lines. Doing so, the code is also faster since there is less copy and sort.
What do you think?
Vincent
New commits:
df628e9  trac #17649: formatting and documentation

f6c2af6  trac #17649: split complicated lines

comment:8 Changed 6 years ago by
 Status changed from needs_review to needs_info
comment:9 Changed 6 years ago by
 Status changed from needs_info to needs_review
Okayokay.... This part of the code really takes too many lines for what it does, but I found no clean/readable way to do it in fewer lines.
Nathann
comment:10 Changed 6 years ago by
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to positive_review
comment:11 Changed 6 years ago by
Wow. Very cool. KTS in Sage. That's a cool news :P
Nathann
comment:12 Changed 6 years ago by
 Status changed from positive_review to needs_work
PDF docs don't build
comment:13 Changed 6 years ago by
 Commit changed from f6c2af6ce39ed44e45607647c67ca724ac283e87 to 005e53e3283b11d0c395b4325b11b1a2c2ab6df2
Branch pushed to git repo; I updated commit sha1. New commits:
005e53e  trac #17649: Typo

comment:14 Changed 6 years ago by
 Status changed from needs_work to positive_review
comment:15 Changed 6 years ago by
 Branch changed from public/17649bis to 005e53e3283b11d0c395b4325b11b1a2c2ab6df2
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #17649: Kirkman Triple Systems (end of the construction)