Changes between Initial Version and Version 6 of Ticket #17648


Ignore:
Timestamp:
01/18/15 06:58:28 (6 years ago)
Author:
ncohen
Comment:

Hello,

What are "those functions"? Can you be more specific in your ticket description?

My excuses. I thought that this would be clear from the diff, but when you reverse A and B in a file, it is true that git can chose to "remove A and add it somewhere else" or "remove B and add it somewhere else". I just updated the description to say that the three functions I moved are the following:

from_frobenius_coordinates
from_beta_numbers
from_exp
from_zero_one
from_core_and_quotient

Also, it looks like you just moved code. Is that what you intended? No new tests etc??

I did not think that there was any need to. The doctests were correct and called Partitions().from_.... That command remains valid. On the other hand, Partition(5).from_... is now invalid.

Nathann

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17648

    • Property Status changed from new to needs_review
    • Property Commit changed from to d37d47d4cc77f318e8bcc21cc69558411458c248
    • Property Branch changed from to public/17648
  • Ticket #17648 – Description

    initial v6  
    1 Those functions do not depend on the parameters given to the `Partitions` constructor, i.e.:
     1The following functions do not depend on the parameters given to the `Partitions` constructor:
     2
     3{{{
     4from_frobenius_coordinates
     5from_beta_numbers
     6from_exp
     7from_zero_one
     8from_core_and_quotient
     9}}}
     10
     11Example:
    212
    313{{{
     
    717}}}
    818
    9 They should belong to `Partitions_all`
     19They should belong to `Partitions_all`, and thise branch moves them there.
    1020
    1121Nathann