Opened 4 years ago

Closed 4 years ago

#17646 closed defect (fixed)

Documentation and default of Graph.show(method="js")

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: graph theory Keywords:
Cc: was Merged in:
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 3b4b729 (Commits) Commit: 3b4b7294e36f3d29f2ca49a6e290e2a6ebf85a70
Dependencies: Stopgaps:

Description

It has been reported [1] that the default behaviour of show(method="js") was not the same as show() when it comes to displaying the vertex labels.

This branch fixes it, and simplifies the doc.

Nathann

[1] https://groups.google.com/d/topic/sage-cloud/-juJKlYGsMY/discussion

Change History (4)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/17646
  • Commit set to 3b4b7294e36f3d29f2ca49a6e290e2a6ebf85a70
  • Status changed from new to needs_review

New commits:

3b4b729trac #17646: Documentation and default of Graph.show(method="js")

comment:2 Changed 4 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

That's an easy patch that is perfectly working (functionality and doc). Thanks Nathann.

comment:3 Changed 4 years ago by ncohen

Thanks!

comment:4 Changed 4 years ago by vbraun

  • Branch changed from public/17646 to 3b4b7294e36f3d29f2ca49a6e290e2a6ebf85a70
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.