Opened 5 years ago

Closed 5 years ago

#17645 closed defect (fixed)

load("object.sobj") is broken in the new sagenb

Reported by: novoselt Owned by:
Priority: blocker Milestone: sage-6.5
Component: notebook Keywords:
Cc: Merged in:
Authors: Karl-Dieter Crisman Reviewers: Jeroen Demeyer, Frédéric Chapoton
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: 71c6032 (Commits) Commit: 71c60325902dc007f9730366751912362ac1eed9
Dependencies: #12212 Stopgaps:

Change History (20)

comment:1 Changed 5 years ago by novoselt

  • Component changed from PLEASE CHANGE to notebook
  • Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.

comment:2 Changed 5 years ago by jdemeyer

I believe this commit is responsible:

  • sagenb/notebook/worksheet.py

    commit 2ea8adb1158ffb5048610552ad36df55fd7ee417
    Author: kcrisman <kcrisman@gmail.com>
    Date:   Wed Dec 3 14:29:38 2014 -0500
    
        Make init.sage work
        
        Ideally, this would later be changed to use `attach` again.
    
    diff --git a/sagenb/notebook/worksheet.py b/sagenb/notebook/worksheet.py
    index 53048a1..6507341 100644
    a b sage.misc.latex.EMBEDDED_MODE=True 
    30443044# gets removed from the sage library.
    30453045from sagenb.notebook.all import *
    30463046try:
    3047     attach(os.path.join(os.environ['DOT_SAGE'], 'init.sage'))
     3047    from sage.misc.preparser import load
     3048    load(os.path.join(os.environ['DOT_SAGE'], 'init.sage'), globals(),attach=True)
    30483049except (KeyError, IOError):
    30493050    pass
    30503051    """ % (os.path.join(os.path.abspath(self.data_directory()),''), misc.DIR)

I guess it suffices to remove the added import line.

Last edited 5 years ago by jdemeyer (previous) (diff)

comment:3 Changed 5 years ago by kcrisman

  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.

comment:4 Changed 5 years ago by kcrisman

This needs a new sagenb package, coming within a few days.

comment:5 Changed 5 years ago by kcrisman

  • Dependencies set to #12212
  • Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

Setting mutual dependency because this sagenb upgrade contains a very minor change in canvas3d that needs #12212.

comment:6 Changed 5 years ago by kcrisman

  • Branch set to u/kcrisman/ticket/17645

comment:7 Changed 5 years ago by kcrisman

  • Authors set to Karl-Dieter Crisman
  • Commit set to bbee29ecb7d90a555882cbcedbfb2cd88d321551
  • Status changed from new to needs_review

Upstream package at http://sage.math.washington.edu/home/kcrisman/sagenb-0.11.3.tar


New commits:

bbee29eUpgrade sagenb to version 0.11.3

comment:8 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-6.5 to sage-pending
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:10 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-6.5

comment:11 Changed 5 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Hang on, https://github.com/sagemath/sagenb/pull/120 needs more testing.

Last edited 5 years ago by jdemeyer (previous) (diff)

comment:12 Changed 5 years ago by jdemeyer

  • Work issues set to disable e-mails by default

comment:13 follow-up: Changed 5 years ago by kcrisman

  • Work issues changed from disable e-mails by default to new sagenb spkg

https://github.com/sagemath/sagenb/pull/338 has been positively reviewed, so 0.11.3.1 will probably come out tomorrow.

comment:14 in reply to: ↑ 13 Changed 5 years ago by jdemeyer

Replying to kcrisman:

0.11.3.1 will probably come out tomorrow.

Can we just make it 0.11.4 instead?

comment:15 Changed 5 years ago by kcrisman

That works too. Did you see my comment there, by the way?

Only issue I see is that if someone had the beta version it would remember the previous config and still send to root@localhost, but for anyone just upgrading normally should be fine; I don't think there is a way to prevent that.

If you agree that is not something worth dealing with, I will make the package today.

comment:16 Changed 5 years ago by git

  • Commit changed from bbee29ecb7d90a555882cbcedbfb2cd88d321551 to 71c60325902dc007f9730366751912362ac1eed9

Branch pushed to git repo; I updated commit sha1. New commits:

71c6032Upgrade sagenb to version 0.11.4

comment:17 Changed 5 years ago by kcrisman

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Work issues new sagenb spkg deleted

Upstream package at ​http://sage.math.washington.edu/home/kcrisman/sagenb-0.11.4.tar

Note I intentionally kept the same branch to keep the history of having 0.11.3 release upstream, but no need to place 0.11.3 in upstream, obviously.

comment:18 Changed 5 years ago by chapoton

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Frédéric Chapoton

Looks good to me. Jeroen ?

comment:19 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:20 Changed 5 years ago by vbraun

  • Branch changed from u/kcrisman/ticket/17645 to 71c60325902dc007f9730366751912362ac1eed9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.