Opened 8 years ago
Closed 7 years ago
#17645 closed defect (fixed)
load("object.sobj") is broken in the new sagenb
Reported by: | novoselt | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-6.5 |
Component: | notebook | Keywords: | |
Cc: | Merged in: | ||
Authors: | Karl-Dieter Crisman | Reviewers: | Jeroen Demeyer, Frédéric Chapoton |
Report Upstream: | Fixed upstream, in a later stable release. | Work issues: | |
Branch: | 71c6032 (Commits, GitHub, GitLab) | Commit: | 71c60325902dc007f9730366751912362ac1eed9 |
Dependencies: | #12212 | Stopgaps: |
Change History (20)
comment:1 Changed 8 years ago by
- Component changed from PLEASE CHANGE to notebook
- Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
- Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.
comment:4 Changed 8 years ago by
This needs a new sagenb package, coming within a few days.
comment:5 Changed 8 years ago by
- Dependencies set to #12212
- Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.
Setting mutual dependency because this sagenb upgrade contains a very minor change in canvas3d that needs #12212.
comment:6 Changed 8 years ago by
- Branch set to u/kcrisman/ticket/17645
comment:7 Changed 8 years ago by
- Commit set to bbee29ecb7d90a555882cbcedbfb2cd88d321551
- Status changed from new to needs_review
Upstream package at http://sage.math.washington.edu/home/kcrisman/sagenb-0.11.3.tar
New commits:
bbee29e | Upgrade sagenb to version 0.11.3
|
comment:8 Changed 8 years ago by
- Description modified (diff)
comment:9 Changed 8 years ago by
- Milestone changed from sage-6.5 to sage-pending
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
comment:10 Changed 8 years ago by
- Milestone changed from sage-pending to sage-6.5
comment:11 Changed 8 years ago by
- Status changed from positive_review to needs_work
Hang on, https://github.com/sagemath/sagenb/pull/120 needs more testing.
comment:12 Changed 8 years ago by
- Work issues set to disable e-mails by default
comment:13 follow-up: ↓ 14 Changed 8 years ago by
- Work issues changed from disable e-mails by default to new sagenb spkg
https://github.com/sagemath/sagenb/pull/338 has been positively reviewed, so 0.11.3.1 will probably come out tomorrow.
comment:14 in reply to: ↑ 13 Changed 8 years ago by
comment:15 Changed 8 years ago by
That works too. Did you see my comment there, by the way?
Only issue I see is that if someone had the beta version it would remember the previous config and still send to root@localhost, but for anyone just upgrading normally should be fine; I don't think there is a way to prevent that.
If you agree that is not something worth dealing with, I will make the package today.
comment:16 Changed 8 years ago by
- Commit changed from bbee29ecb7d90a555882cbcedbfb2cd88d321551 to 71c60325902dc007f9730366751912362ac1eed9
Branch pushed to git repo; I updated commit sha1. New commits:
71c6032 | Upgrade sagenb to version 0.11.4
|
comment:17 Changed 8 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
- Work issues new sagenb spkg deleted
Upstream package at http://sage.math.washington.edu/home/kcrisman/sagenb-0.11.4.tar
Note I intentionally kept the same branch to keep the history of having 0.11.3 release upstream, but no need to place 0.11.3 in upstream, obviously.
comment:18 Changed 8 years ago by
- Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Frédéric Chapoton
Looks good to me. Jeroen ?
comment:19 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:20 Changed 7 years ago by
- Branch changed from u/kcrisman/ticket/17645 to 71c60325902dc007f9730366751912362ac1eed9
- Resolution set to fixed
- Status changed from positive_review to closed
I believe this commit is responsible:
sagenb/notebook/worksheet.py
I guess it suffices to remove the added
import
line.