Opened 4 years ago

Closed 4 years ago

#17641 closed defect (fixed)

stricmp is being deprecated in Cygwin

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.5
Component: porting: Cygwin Keywords: cygwin singular
Cc: gouezel, tscrim Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7727566 (Commits) Commit: 772756647f5fdb7fe78bddc8ab43603f93a08a62
Dependencies: Stopgaps:

Description (last modified by jpflori)

stricmp is being deprecated in Cygwin See https://cygwin.com/ml/cygwin/2014-10/msg00359.html One should use strcasecmp

This makes Singular build fail on Cygwin32 (not Cygwin64 at the moment).

Attachments (1)

stricmp.patch (379 bytes) - added by jpflori 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by jpflori

  • Description modified (diff)

Changed 4 years ago by jpflori

comment:2 Changed 4 years ago by tscrim

  • Cc tscrim added

comment:3 Changed 4 years ago by vdelecroix

Hi Jean-Pierre,

Did you report upstream? The corresponding field of this track ticket is still N/A.

Vincent

comment:4 Changed 4 years ago by jpflori

Nope, and I won't do so before end of february when I come back to France. Feel free to do it, but note it is not a high priority as:

  • it only affects Cygwin32
  • I did not check the state of Singular 4-0-x.

comment:5 Changed 4 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/17641
  • Cc gouezel added
  • Commit set to 772756647f5fdb7fe78bddc8ab43603f93a08a62
  • Keywords cygwin singular added
  • Status changed from new to needs_review

New commits:

7727566stricmp is being depercated on Cygwin.

comment:6 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM.

comment:7 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jpflori/ticket/17641 to 772756647f5fdb7fe78bddc8ab43603f93a08a62
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.