Opened 7 years ago

Last modified 7 years ago

#17626 needs_info enhancement

inherit Group from Monoid

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.5
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: u/dkrenn/new-monoid-class (Commits, GitHub, GitLab) Commit: 2607990dddcfbf0f68a6b40c5130e3b65c0a1cac
Dependencies: Stopgaps:

Status badges

Description

The class Group in sage.groups.group is inherited from Parent but not from Monoid since no "nice" monoid-class exists. There is only Monoid_class which seems to be very simplified.

The aim of this ticket is to create a class Monoid and use it as a base-class for Group.

Change History (3)

comment:1 Changed 7 years ago by dkrenn

  • Branch set to u/dkrenn/new-monoid-class
  • Commit set to 2607990dddcfbf0f68a6b40c5130e3b65c0a1cac
  • Status changed from new to needs_info

Last 10 new commits:

a097639add monoid.pxd
b2589b3remove accidentally added method "order" from monoid
8ff4faausing "super" in __init__
3a7b312code rewrapping
63343d8improve docstrings
c51a914cimport Monoid in group.pyx
5296eeederive Group from Monoid
7730f60use super(...).__init__
8e088c0remove duplicate code
2607990restructured imports and removed non-needed

comment:2 Changed 7 years ago by dkrenn

in c51a914 the importing of Monoid in group.pyx fails (sage -t) with

Traceback (most recent call last):
...
AttributeError: 'module' object has no attribute 'all'

Need help... :)

Last edited 7 years ago by dkrenn (previous) (diff)

comment:3 Changed 7 years ago by dkrenn

  • Summary changed from inherite Group from Monoid to inherit Group from Monoid
Note: See TracTickets for help on using tickets.