Opened 7 years ago
Closed 7 years ago
#17625 closed enhancement (fixed)
Remove init_csage_module()
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.5 |
Component: | porting: Cygwin | Keywords: | |
Cc: | tscrim, gouezel, jpflori | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Jean-Pierre Flori |
Report Upstream: | N/A | Work issues: | |
Branch: | 90f6e95 (Commits, GitHub, GitLab) | Commit: | 90f6e9576eda1fa319a94a2dfaaf7681c41153c7 |
Dependencies: | Stopgaps: |
Description (last modified by )
The c_lib
function init_csage_module()
only does something on Cygwin 32, but it seems no longer needed.
Change History (8)
comment:1 Changed 7 years ago by
- Description modified (diff)
comment:2 Changed 7 years ago by
- Branch set to u/jdemeyer/ticket/17625
- Created changed from 01/12/15 16:20:39 to 01/12/15 16:20:39
- Modified changed from 01/12/15 16:27:26 to 01/12/15 16:27:26
comment:3 Changed 7 years ago by
- Commit set to 7cb110ccd505de031b4e97c72a7555a9cc2c8198
- Status changed from new to needs_review
comment:4 Changed 7 years ago by
- Component changed from c_lib to porting: Cygwin
comment:5 Changed 7 years ago by
I'm deeply sorry Jeroen. I was in the process of testing this but got some issues with my Cygwin 32 bits install, got quite in a rush when leaving Bordeaux and then went off the internet for one month. This is one of my top priority Sage related things to do next week when I'll be back to my usual routine.
comment:6 Changed 7 years ago by
- Commit changed from 7cb110ccd505de031b4e97c72a7555a9cc2c8198 to 90f6e9576eda1fa319a94a2dfaaf7681c41153c7
Branch pushed to git repo; I updated commit sha1. New commits:
90f6e95 | Merge remote-tracking branch 'origin/develop' into t/17625/ticket/17625
|
comment:7 Changed 7 years ago by
- Reviewers set to Jean-Pierre Flori
- Status changed from needs_review to positive_review
As expected, works fine.
comment:8 Changed 7 years ago by
- Branch changed from u/jdemeyer/ticket/17625 to 90f6e9576eda1fa319a94a2dfaaf7681c41153c7
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Remove init_csage_module()