Opened 4 years ago

Closed 4 years ago

#17619 closed defect (fixed)

Add missing libraries on cygwin

Reported by: gouezel Owned by:
Priority: major Milestone: sage-6.5
Component: porting: Cygwin Keywords:
Cc: jpflori Merged in:
Authors: Sebastien Gouezel Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 4e37400 (Commits) Commit: 4e37400aaa42d454ac8fee1796edbef201d21b8a
Dependencies: Stopgaps:

Description (last modified by gouezel)

Linking on cygwin is rather strict, contrary to linux: all libraries should be explicitely specified. This patch adds the missing libraries in module_list.py

Change History (5)

comment:1 Changed 4 years ago by gouezel

  • Branch set to u/gouezel/add_missing_libraries_on_cygwin

comment:2 Changed 4 years ago by gouezel

  • Authors set to Sebastien Gouezel
  • Commit set to 4e37400aaa42d454ac8fee1796edbef201d21b8a
  • Component changed from PLEASE CHANGE to porting: Cygwin
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

4e37400Add missing library gmp in module_list.py

comment:3 Changed 4 years ago by tscrim

  • Cc jpflori added

comment:4 Changed 4 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Looks sensible (and needed because of the inclusion of bitset.pxi in these two files).

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/gouezel/add_missing_libraries_on_cygwin to 4e37400aaa42d454ac8fee1796edbef201d21b8a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.