Opened 4 years ago

Closed 4 years ago

#17615 closed enhancement (fixed)

Move bordeaux_2008 into thematic_tutorials

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: documentation Keywords:
Cc: kcrisman, jhpalmieri Merged in:
Authors: Nathann Cohen Reviewers: Karl-Dieter Crisman, David Coudert
Report Upstream: N/A Work issues:
Branch: e4f3206 (Commits) Commit: e4f3206b52f470340e52eba5aee89ce6cbffc680
Dependencies: #17614 Stopgaps:

Description

Like for #17614, the document entitled "Three Lectures about Explicit Methods in Number Theory Using Sage" is a document of its own though it is literally a thematic tutorial. This branch moves it where it belongs.

Note: in order to look at this branch's diff you should use git diff -M HEAD ^develop. Otherwise you will see files being added/removed while they are only renamed. The -M option makes this clear.

Nathann

Change History (19)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/17615
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to 3c4d49938a34fe93c88c4c584247ac924c2d6166

Branch pushed to git repo; I updated commit sha1. New commits:

4645442trac #17614: Move numerical_sage to thematic_tutorials (and only that)
612c3cftrac #17614: Update the links
c07c428trac #17615: Move bordeaux_2008 into thematic_tutorials/explicit_methods_in_number_theory/ (and only that)
3c4d499trac #17615: Update the links

comment:3 follow-up: Changed 4 years ago by kcrisman

I won't be thinking about these two tickets immediately, but did want to point out that at least a couple of them may have localizations and I wonder where those would fit. Also be careful about the actual Sage webpage which would need to have links change, probably (looks like you did the "website" in src/doc).

comment:4 in reply to: ↑ 3 ; follow-up: Changed 4 years ago by ncohen

I won't be thinking about these two tickets immediately, but did want to point out that at least a couple of them may have localizations

There was no localization problem that I saw, and in particular both html and pdf documentation were built successfully. There is not a single non-ascii character in any of those two folders.

and I wonder where those would fit.

You mean "among the thematic tutorials" ? Nothing unusual there:

  • "Numerical Computations" that contains the bordeaux2008 document and the LP tutorial
  • "Number Theory" contains three documents, among which the moved 'three lectures [...]'.

Also be careful about the actual Sage webpage which would need to have links change, probably (looks like you did the "website" in src/doc).

I learned the existence of that file while reviewing your patch recently, and modified it in those two branches. It looks good.

Nathann

Last edited 4 years ago by ncohen (previous) (diff)

comment:5 in reply to: ↑ 4 ; follow-up: Changed 4 years ago by kcrisman

There was no localization problem that I saw, and in particular both html and pdf documentation were built successfully. There is not a single non-ascii character in any of those two folders.

No, I meant I think that someone has translated at least one of these documents already! So they live in some other doc/xy folder. Maybe those are only under review.

Also be careful about the actual Sage webpage which would need to have links change, probably (looks like you did the "website" in src/doc).

I learned the existence of that file while reviewing your patch recently, and modified it in those two branches. It looks good.

Right, but what I mean is that the actual Sage website also has links, see https://github.com/sagemath/website which is not the same.

comment:6 in reply to: ↑ 5 Changed 4 years ago by ncohen

Hello,

No, I meant I think that someone has translated at least one of these documents already! So they live in some other doc/xy folder. Maybe those are only under review.

It seems so. There is no folder with a name similar to any of those two in the folder corresponding to other languages.

Right, but what I mean is that the actual Sage website also has links, see https://github.com/sagemath/website which is not the same.

There does not seem to be any link toward any of those two documents on sagemath.org.

Nathann

comment:7 follow-up: Changed 4 years ago by kcrisman

Incorrect. See http://sagemath.org/help.html#SageStandardDoc and

Numerical Sage, PDF — how to do numerical computing with Sage Explicit Methods in Number Theory, PDF — computing with number fields and modular forms

comment:8 in reply to: ↑ 7 Changed 4 years ago by ncohen

Incorrect. See http://sagemath.org/help.html#SageStandardDoc and

Thank you for pointing this out, I missed it. Can it be done with a sage branch, or is it orthogonal ?

Nathann

comment:9 follow-up: Changed 4 years ago by kcrisman

Orthogonal (you can also email Harald for questions, or do a PR there), but obviously related.

comment:10 in reply to: ↑ 9 Changed 4 years ago by ncohen

Orthogonal (you can also email Harald for questions, or do a PR there), but obviously related.

Okay. I will do this when those two tickets will be reviewed. There is always some time before a positive review and the next update of the online doc.

Nathann

comment:11 follow-up: Changed 4 years ago by dcoudert

  • Reviewers set to Karl-Dieter Crisman, David Coudert
  • Status changed from needs_review to positive_review

For me this patch is working correctly, and since the modification of some links pointing to these pages cannot be done in this patch, I propose to change the status to positive review.

Nathann, don't forget to ask for the required modifications.

comment:12 in reply to: ↑ 11 Changed 4 years ago by ncohen

Nathann, don't forget to ask for the required modifications.

Done, thanks.

comment:13 Changed 4 years ago by vbraun

Pushes this test over the threshold:

sage -t --long --warn-long 70.4 src/sage/misc/sagedoc.py
**********************************************************************
File "src/sage/misc/sagedoc.py", line 1039, in sage.misc.sagedoc.?
Failed example:
    len(search_doc('tree', whole_word=True, interact=False).splitlines()) < 1000  # long time
Expected:
    True
Got:
    False

comment:14 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

comment:15 Changed 4 years ago by git

  • Commit changed from 3c4d49938a34fe93c88c4c584247ac924c2d6166 to cf7b89a79044b90b1f99785a1d4fcd289301bd0c

Branch pushed to git repo; I updated commit sha1. New commits:

c949950trac #17615: Merged with 6.5.beta6
cf7b89atrac #17615: Broken doctest

comment:16 Changed 4 years ago by ncohen

  • Status changed from needs_work to positive_review

comment:17 Changed 4 years ago by git

  • Commit changed from cf7b89a79044b90b1f99785a1d4fcd289301bd0c to e4f3206b52f470340e52eba5aee89ce6cbffc680
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

21dbfd8trac #17615: Merged with 6.5.beta6
e4f3206trac #17615: Broken doctest

comment:18 Changed 4 years ago by ncohen

  • Status changed from needs_review to positive_review

comment:19 Changed 4 years ago by vbraun

  • Branch changed from public/17615 to e4f3206b52f470340e52eba5aee89ce6cbffc680
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.