Opened 5 years ago
Closed 4 years ago
#17614 closed enhancement (fixed)
Move numerical_sage into thematic_tutorials
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.5 
Component:  documentation  Keywords:  
Cc:  kcrisman, jhpalmieri  Merged in:  
Authors:  Nathann Cohen  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  5c2bd4d (Commits)  Commit:  5c2bd4dfa3f64adcb29c93d09fb426a913d041c8 
Dependencies:  Stopgaps: 
Description (last modified by )
In its current state, 'numerical_sage' is a 'document' of its own while it is literally a 'thematic tutorial'. This branch moves the foler where it belongs, and updates the links.
Note: in order to look at this branch's diff you should use git diff M HEAD ^develop
. Otherwise you will see files being added/removed while they are only renamed. The M
option makes this clear.
Nathann
Change History (16)
comment:1 Changed 5 years ago by
 Branch set to public/17614
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit set to bc5619b4fea2f40f9566ab80f96d074ed90ded77
comment:3 Changed 5 years ago by
 Description modified (diff)
comment:4 Changed 5 years ago by
 Commit changed from bc5619b4fea2f40f9566ab80f96d074ed90ded77 to 612c3cf444c1cd10e4889947db90f53b551c2b76
comment:5 Changed 4 years ago by
 Reviewers set to David Coudert
 Status changed from needs_review to needs_work
The patch moves properly numerical_sage
to the thematic_tutorials
.
I have observed the following problems that may or not be related to this patch:
 At the end of page
.../sage/src/doc/output/html/en/thematic_tutorials/numerical_sage/index.html
, I click onIndex
to go to page.../sage/src/doc/output/html/en/thematic_tutorials/genindex.html
. Problem: the 'Index pages by letter:' is empty and the pageFull index on one page (can be huge)
is also empty. So pagesthematic_tutorials/genindex.html
andthematic_tutorials/genindexall.html
are empty.
 At the end of page:
.../sage/src/doc/output/html/en/thematic_tutorials/toctree.html
, the linkIndices and tables
points to.../sage/src/doc/output/html/en/thematic_tutorials/numerical_sage/index.html#indicesandtables
comment:6 Changed 4 years ago by
 Status changed from needs_work to needs_review
Hello,
It was not a problem from this patch, but indeed this 'indices and tables' section is quite useless. I remove it in an additional commit.
Nathann
comment:7 Changed 4 years ago by
 Commit changed from 612c3cf444c1cd10e4889947db90f53b551c2b76 to 7abc30334f3d6c6137dc369852a99153b19a1c9b
Branch pushed to git repo; I updated commit sha1. New commits:
7abc303  trac #17614: Review

comment:8 Changed 4 years ago by
 Status changed from needs_review to positive_review
Looks good to me.
comment:9 Changed 4 years ago by
Thanks !
Nathann
comment:10 Changed 4 years ago by
Looks good to me too ;)
comment:11 Changed 4 years ago by
I don't often have two reviewers competing to click on 'positive_review'. Anyway if you have some momentum there are still some doc tickets to review, including #17615 which is a copy of that one ^^;
But thank you for your help on this ticket anyway!!!
Nathann
comment:12 Changed 4 years ago by
Conflicts, probably with #17605
comment:13 Changed 4 years ago by
 Status changed from positive_review to needs_work
comment:14 Changed 4 years ago by
 Commit changed from 7abc30334f3d6c6137dc369852a99153b19a1c9b to 5c2bd4dfa3f64adcb29c93d09fb426a913d041c8
Branch pushed to git repo; I updated commit sha1. New commits:
a846240  trac #17605: "How to call C code from Sage" thematic tutorial

2ad9b51  trac #17605: Make it work for libraries

96177d8  trac #17605: no trace that Sage is written by jews

bd0dae3  trac #17605: Errors...

5f20f0a  trac #17605: Remove useless (and problematic) compilation (+indentation fixes)

2f37b6f  trac #17605: Syntax highlighting

5c2bd4d  trac #17614: Merged with #17605

comment:15 Changed 4 years ago by
 Status changed from needs_work to positive_review
comment:16 Changed 4 years ago by
 Branch changed from public/17614 to 5c2bd4dfa3f64adcb29c93d09fb426a913d041c8
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Move numerical_sage to thematic_tutorials (and only that)
Update the links