Opened 5 years ago

Closed 5 years ago

#17602 closed defect (fixed)

function_field_order should raise TypeError if conversion fails

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: f46c53d (Commits) Commit: f46c53dd9cce39eda24df08481913267ba915e5c
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Change ValueError to TypeError in two places.

Change History (7)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17602
  • Created changed from 01/08/15 14:13:18 to 01/08/15 14:13:18
  • Modified changed from 01/08/15 14:13:18 to 01/08/15 14:13:18

comment:2 Changed 5 years ago by git

  • Commit set to f46c53dd9cce39eda24df08481913267ba915e5c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f46c53dRaise TypeError instead of ValueError if conversion fails

comment:3 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

comment:4 follow-up: Changed 5 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

I'm not sure I like the principle of using TypeErrors to indicate that something doesn't have the right parent. But as far as I understand this is what the coercion code does, so why not. I'm wondering if in the long run we shouldn't introduce a ParentError, though.

comment:5 Changed 5 years ago by jdemeyer

  • Reviewers set to Marc Mezzarobba

comment:6 in reply to: ↑ 4 Changed 5 years ago by jdemeyer

Replying to mmezzarobba:

I'm wondering if in the long run we shouldn't introduce a ParentError, though.

Not a bad idea actually, especially since it sometimes makes sense to differentiate between ParentError and a TypeError for other reasons.

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17602 to f46c53dd9cce39eda24df08481913267ba915e5c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.