Opened 6 years ago
Closed 16 months ago
#17598 closed defect (fixed)
fixedmod padic integers as polynomial roots
Reported by:  gagern  Owned by:  

Priority:  major  Milestone:  sage9.0 
Component:  padics  Keywords:  padicIMA, padicBordeaux 
Cc:  jakobkroeker  Merged in:  
Authors:  David Roe  Reviewers:  Xavier Caruso 
Report Upstream:  N/A  Work issues:  
Branch:  b070a12 (Commits)  Commit:  b070a12a9f23f26f934cb99a5f27d55c5ac0889d 
Dependencies:  Stopgaps: 
Description
I think the following should not return an empty list:
sage: cyclotomic_polynomial(3).roots(Zp(739, 566, type="fixedmod")) []
The problem appears to be specific to the fixedmod
type. For cappedrel
and cappedabs
, two roots are found as expected. So if there is no more elegant solution, one could always compute the result in the cappedabs
field and then cast to fixedmod
.
Change History (11)
comment:1 Changed 4 years ago by
 Cc jakobkroeker added
comment:2 Changed 4 years ago by
comment:3 Changed 3 years ago by
 Keywords padicIMA added
comment:4 Changed 17 months ago by
 Keywords padicBordeaux added
comment:5 Changed 17 months ago by
 Branch set to u/roed/FMroots
comment:6 Changed 17 months ago by
 Commit set to b070a12a9f23f26f934cb99a5f27d55c5ac0889d
 Status changed from new to needs_review
New commits:
b070a12  Fix some typos and trailing whitespace in padic_generic; change _roots_from_factorization to support fixed mod padics

comment:7 Changed 17 months ago by
comment:8 Changed 16 months ago by
 Reviewers set to Xavier Caruso
 Status changed from needs_review to positive_review
Thanks for fixing this bug.
comment:9 Changed 16 months ago by
 Milestone changed from sage6.5 to sage8.9
comment:10 Changed 16 months ago by
 Milestone changed from sage8.9 to sage9.0
moving milestone to 9.0 (after release of 8.9)
comment:11 Changed 16 months ago by
 Branch changed from u/roed/FMroots to b070a12a9f23f26f934cb99a5f27d55c5ac0889d
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
When computing the roots, one step gives cappedprecision.
Then x with cappedprecision does not compare == to its image in the same field with fixedmodulus.
So the root is excluded as not being in the given field.