Opened 6 years ago

Closed 6 years ago

#17597 closed enhancement (fixed)

The trace of a hypergraph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 20107e5 (Commits) Commit: 20107e555eb3a4c64447a18339b218978a2fc98d
Dependencies: #17577 Stopgaps:

Description

With this, one can compute the trace of a hypergraph !

Nathann

Change History (10)

comment:1 Changed 6 years ago by ncohen

  • Branch set to public/17597
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by git

  • Commit set to 61352630a5ed7cc5ca666dd494d6211f43e65fbd

Branch pushed to git repo; I updated commit sha1. New commits:

​749ad0btrac #17577: IncidenceStructure.induced_substructure
​53687a9trac #17577: Merged with 6.5.beta5
​6135263trac #17597: The trace of a hypergraph

comment:3 Changed 6 years ago by git

  • Commit changed from 61352630a5ed7cc5ca666dd494d6211f43e65fbd to 233423b75fec463bd8a73c253e0a02ec3d14bcb8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​57ceae3trac #17577: Merged with 6.5.beta5
​e7ff930trac #17577: Bug with labels
​0384cc8trac #17577 reviewer commit
​2bf5a1ctrac #17597: The trace of a hypergraph
​233423btrac #17597: documentation + pep8 + typo

comment:4 Changed 6 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

Hi,

Rebased over the positively reviewed #17577. Small commit.

If you are satisfied, put to positive review.

Vincent

comment:5 Changed 6 years ago by ncohen

O_o

Weird, I was pretty sure that I had used a new trick in this commit. I will add something in a second, you'll see.

Nathann

comment:6 Changed 6 years ago by git

  • Commit changed from 233423b75fec463bd8a73c253e0a02ec3d14bcb8 to 20107e555eb3a4c64447a18339b218978a2fc98d

Branch pushed to git repo; I updated commit sha1. New commits:

​20107e5trac #17597: A trick

comment:7 Changed 6 years ago by ncohen

Here it is ! I agree with your commits, now it's your turn ;-)

Nathann

comment:8 follow-up: Changed 6 years ago by vdelecroix

  • Status changed from needs_review to positive_review

Useful!

comment:9 in reply to: ↑ 8 Changed 6 years ago by ncohen

Useful!

There must be some patch in needs_review somewhere which uses that trick. I was sure I wrote some code with it O_o

Nathann

comment:10 Changed 6 years ago by vbraun

  • Branch changed from public/17597 to 20107e555eb3a4c64447a18339b218978a2fc98d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.