Opened 6 years ago
Closed 6 years ago
#17594 closed enhancement (fixed)
iOA of type OA(k,n)OA(k,u)2.OA(k,1)
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.5 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  5934845 (Commits, GitHub, GitLab)  Commit:  59348453411d449eb4249af0fdd91eda8e5b2067 
Dependencies:  #17149  Stopgaps: 
Description
This branch extends a previous case that only worked for three holes of size 1.
The algorithm is greedy but the implementation is a bit painful :/
Nathann
Change History (16)
comment:1 Changed 6 years ago by
 Branch set to public/17594
 Component changed from PLEASE CHANGE to combinatorial designs
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Commit set to e4d1622211e7d754a30fe5ea8d31928889aeb5c0
comment:3 Changed 6 years ago by
 Commit changed from e4d1622211e7d754a30fe5ea8d31928889aeb5c0 to cfd71714db12f963d3b5d9c49460bbb45068c00a
Branch pushed to git repo; I updated commit sha1. New commits:
cfd7171  trac #17594: Add an URL

comment:4 Changed 6 years ago by
 Summary changed from Holes of size OA(k,n)OA(k,u)2.OA(k,1) to iOA of type OA(k,n)OA(k,u)2.OA(k,1)
comment:5 Changed 6 years ago by
 Status changed from needs_review to needs_work
Error building the documentation. Traceback (most recent call last): ... OSError: [combinat ] sage/combinat/designs/orthogonal_arrays.py:docstring of sage.combinat.designs.orthogonal_arrays.OAMainFunctions.is_available:6: WARNING: Block quote ends without a blank line; unexpected unindent.
comment:6 Changed 6 years ago by
I found the pb (there was an unexpected "x" at the begining of a line!!). I am on it.
Vincent
comment:7 Changed 6 years ago by
 Commit changed from cfd71714db12f963d3b5d9c49460bbb45068c00a to 311cd172c2cd1bdc90449f1f01931530b3f523b9
comment:8 followup: ↓ 9 Changed 6 years ago by
 Status changed from needs_work to needs_review
Hello Nathann,
It seems to work but we do have very few examples of OA(k,n)  OA(k,u)
, right?
sage: for n in range(2,1000): ....: if designs.incomplete_orthogonal_array(4,n,[2],existence=True): ....: print n 9
Vincent
comment:9 in reply to: ↑ 8 Changed 6 years ago by
Hello !
Sorry for this 'x': actually, I already fixed that in this ticket's dependency #17149 (it is closed but not yet in a beta)
It seems to work but we do have very few examples of
OA(k,n)  OA(k,u)
, right?sage: for n in range(2,1000): ....: if designs.incomplete_orthogonal_array(4,n,[2],existence=True): ....: print n 9
With this code you only test OA(k,n)OA(k,2)
. Try this:
sage: for i in range(2,1000): ....: for j in range(2,i): ....: if designs.incomplete_orthogonal_array(4,i,[j],existence=True): ....: print "OA({},{})OA({},{})".format(4,i,4,j) ....: OA(4,9)OA(4,2) OA(4,16)OA(4,3) OA(4,17)OA(4,4) OA(4,25)OA(4,6) OA(4,26)OA(4,5) OA(4,30)OA(4,5) OA(4,36)OA(4,5) OA(4,36)OA(4,7) OA(4,37)OA(4,6) OA(4,41)OA(4,10) OA(4,42)OA(4,7) ...
If you have a hole of size 3 in an OA, you do not necessarily have a hole of size 2. It's not a 2.OA(k,1)
, it's a OA(k,2)
!
Nathann
comment:10 Changed 6 years ago by
Ahahahah. I am ashamed. Yeah, your code is much simpler :P
comment:11 Changed 6 years ago by
Do we get this in ? I see nothing wrong with your commit, so if mine is fine for you ?...
Nathann
comment:12 Changed 6 years ago by
comment:13 Changed 6 years ago by
 Commit changed from 311cd172c2cd1bdc90449f1f01931530b3f523b9 to 59348453411d449eb4249af0fdd91eda8e5b2067
comment:14 Changed 6 years ago by
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to positive_review
... no more conflicts ;)
comment:15 Changed 6 years ago by
Rebasing is so cool. Thanks for the review!
Nathann
comment:16 Changed 6 years ago by
 Branch changed from public/17594 to 59348453411d449eb4249af0fdd91eda8e5b2067
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #17149: iOA with big holes through product of OA
trac #17149: y>sum_of_holes, x>number_of_holes, holes_sizes>holes
trac #17149: Code cleaning
trac #17149: OA(10,1620)
trac #17149: OA(9,1078)
trac #17149: OA(9,1612)
trac #17149: Merged with 6.5.beta5
trac #17594: Holes of size OA(k,n)OA(k,u)2.OA(k,1)