Opened 5 years ago

Closed 5 years ago

#17577 closed enhancement (fixed)

IncidenceStructure.induced_substructure

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: combinatorial designs Keywords:
Cc: vdelecroix, dimpase Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 0384cc8 (Commits) Commit: 0384cc82ad7f1784d28473ea9781cef94c1ff93e
Dependencies: Stopgaps:

Description

A function to return the subcollection of edges contained in a given set X.

Nathann

Change History (6)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17577
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 749ad0b181f1bea2fb7d58dda82310e96371d1e2

Branch pushed to git repo; I updated commit sha1. New commits:

​749ad0btrac #17577: IncidenceStructure.induced_substructure

comment:3 Changed 5 years ago by git

  • Commit changed from 749ad0b181f1bea2fb7d58dda82310e96371d1e2 to e7ff9304dc91db662a608d1861e317cffd28966e

Branch pushed to git repo; I updated commit sha1. New commits:

​57ceae3trac #17577: Merged with 6.5.beta5
​e7ff930trac #17577: Bug with labels

comment:4 Changed 5 years ago by chapoton

  • Branch changed from u/ncohen/17577 to public/ticket/17577
  • Commit changed from e7ff9304dc91db662a608d1861e317cffd28966e to 0384cc82ad7f1784d28473ea9781cef94c1ff93e
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Looks good to me. I allowed myself to correct some pep8 points (yes, I know).

New commits:

​0384cc8trac #17577 reviewer commit

comment:5 Changed 5 years ago by ncohen

Wow. Thanks for this quick review :-)

Nathann

comment:6 Changed 5 years ago by vbraun

  • Branch changed from public/ticket/17577 to 0384cc82ad7f1784d28473ea9781cef94c1ff93e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.