Opened 8 years ago

Closed 7 years ago

#17562 closed defect (fixed)

Implement and use get_unsafe()/set_unsafe() for vectors

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.5
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: d250a42 (Commits, GitHub, GitLab) Commit: d250a4212ec9d636876560fe480e1af8dc2ea452
Dependencies: #17585, #17850 Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Use get_unsafe() and set_unsafe() in the generic __getitem__ and __setitem__ methods for free module elements (a.k.a. vectors).

This should also fix

sage: v=vector(RR,range(6),sparse=True)
sage: v[::2]
(0.000000000000000, 1.00000000000000, 2.00000000000000, 3.00000000000000, 4.00000000000000, 5.00000000000000)

Change History (22)

comment:1 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/17562
Created: Dec 29, 2014, 10:56:38 AMDec 29, 2014, 10:56:38 AM
Modified: Dec 29, 2014, 10:56:38 AMDec 29, 2014, 10:56:38 AM

comment:2 Changed 8 years ago by git

Commit: b6f6e8cb339207e88c646f0383f87db7feefea74

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b6f6e8cImprove and fix __getitem__ and __setitem__

comment:3 Changed 8 years ago by Jeroen Demeyer

Dependencies: #10513

comment:4 Changed 8 years ago by Jeroen Demeyer

Summary: FIx vector slicingFix vector slicing

comment:5 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Fix vector slicingImplement and use get_unsafe()/set_unsafe() for vectors

comment:6 Changed 8 years ago by git

Commit: b6f6e8cb339207e88c646f0383f87db7feefea74bcae9f8bcea3232e2bc8688fb5e3cab3a20c2df1

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

54eed61Trac 10513: move various base_extend() and change_ring() methods to Module
ed13085Trac 10513: various additions, fixes and cleanups
5126b66Trac 10513: remove source line number in doctest
ddda401Merge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
2bb997bMerge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
ed6bbf1Trac 10513: fix doctest
a19e2c5Merge branch 'develop' into ticket/10513-coercion_and_categories_for_modules
2f52a3cTrac 10513: remove unnecessary FreeModule_generic_field.__echelonized_basis_matrix
2d7f075Trac 10513: small documentation improvement
bcae9f8Improve and fix __getitem__ and __setitem__

comment:7 Changed 8 years ago by git

Commit: bcae9f8bcea3232e2bc8688fb5e3cab3a20c2df1027a1967d35cdc0db783817d4667964a8ee4a89f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

027a196Implement get_unsafe() and set_unsafe() for vectors

comment:8 Changed 8 years ago by git

Commit: 027a1967d35cdc0db783817d4667964a8ee4a89f190d4e070eec14223a6170188c1d7a94ec370f60

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

190d4e0Implement get_unsafe() and set_unsafe() for vectors

comment:9 Changed 8 years ago by Jeroen Demeyer

Dependencies: #10513#10513, #17570
Description: modified (diff)

comment:10 Changed 8 years ago by Jeroen Demeyer

Dependencies: #10513, #17570#10513
Description: modified (diff)

comment:11 Changed 8 years ago by Jeroen Demeyer

Dependencies: #10513#17585

comment:12 Changed 8 years ago by git

Commit: 190d4e070eec14223a6170188c1d7a94ec370f604639cd43869107b260e8c0e68ced045faec6433b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dbca6bbImplement coordinate_ring() for free module elements
34ba37dBetter doctests for basis_matrix()
4639cd4Implement get_unsafe() and set_unsafe() for vectors

comment:13 Changed 8 years ago by git

Commit: 4639cd43869107b260e8c0e68ced045faec6433bf398133036e1c7d8c628068e76786f702c639fd2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f398133Implement get_unsafe() and set_unsafe() for vectors

comment:14 Changed 8 years ago by git

Commit: f398133036e1c7d8c628068e76786f702c639fd256cc93b6246ccdad99d1195790fd817c6afab84c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ab7be31Merge remote-tracking branch 'origin/develop' into HEAD
56cc93bImplement get_unsafe() and set_unsafe() for vectors

comment:15 Changed 8 years ago by git

Commit: 56cc93b6246ccdad99d1195790fd817c6afab84c345f2d83f63d5d049a8c0525c9a4fd4144f470cd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

345f2d8Implement get_unsafe() and set_unsafe() for vectors

comment:16 Changed 8 years ago by Jeroen Demeyer

Dependencies: #17585#17585, #17850

comment:17 Changed 8 years ago by git

Commit: 345f2d83f63d5d049a8c0525c9a4fd4144f470cda8a52bda45fd89815a0316e1fedcfbd422462d2f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3a19fabAdd coordinate_ring argument to free module constructors
6f65751Merge remote-tracking branch 'origin/develop' into HEAD
a8a52bdImplement get_unsafe() and set_unsafe() for vectors

comment:18 Changed 8 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer

comment:19 Changed 8 years ago by Jeroen Demeyer

Status: newneeds_review

comment:20 Changed 8 years ago by git

Commit: a8a52bda45fd89815a0316e1fedcfbd422462d2fd250a4212ec9d636876560fe480e1af8dc2ea452

Branch pushed to git repo; I updated commit sha1. New commits:

d250a42Merge tag '6.6.beta2' into t/17562/ticket/17562

comment:21 Changed 8 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

Looks good.

(follow-up: #18029)

comment:22 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/ticket/17562d250a4212ec9d636876560fe480e1af8dc2ea452
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.