Opened 6 years ago
Closed 6 years ago
#17557 closed defect (fixed)
creating a (136,4,1)-BIBD raises an exception
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.5 |
Component: | combinatorial designs | Keywords: | |
Cc: | vdelecroix | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | 8dd0592 (Commits) | Commit: | 8dd05923ce7f06ddf314a9e3800d5deb5a32e2db |
Dependencies: | Stopgaps: |
Description
Just a bug
sage: designs.balanced_incomplete_block_design(136,4) ... TypeError: unsupported operand type(s) for +: 'TransversalDesign' and 'list'
Change History (16)
comment:1 Changed 6 years ago by
- Branch set to u/ncohen/17557
- Commit set to 47cc3870e099232ecb1470e6a8e8114f64e985dc
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Commit changed from 47cc3870e099232ecb1470e6a8e8114f64e985dc to ece8d5af83dbe04e807b7b4cede78ab6f4cbdbab
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ece8d5a | trac #17557: creating a (136,4,1)-BIBD raises an exception
|
comment:3 Changed 6 years ago by
Hi Nathann,
What about a doctest?
Vincent
comment:4 Changed 6 years ago by
- Commit changed from ece8d5af83dbe04e807b7b4cede78ab6f4cbdbab to 4a3c2032f99bed585671b67b0fc530dc68c38012
Branch pushed to git repo; I updated commit sha1. New commits:
4a3c203 | trac #17557: Doctest
|
comment:5 Changed 6 years ago by
I can't do anything smarter than that !
Nathann
comment:6 follow-up: ↓ 9 Changed 6 years ago by
- Branch changed from u/ncohen/17557 to u/vdelecroix/17557
- Commit changed from 4a3c2032f99bed585671b67b0fc530dc68c38012 to 066afc235f2e14bccaec90493bd14c42659152b9
Hello,
The values from 0
to 99
were already tested in a loop above. And it would be better if the specific value v=136
is tested alone. See my commit.
Vincent
New commits:
066afc2 | trac #17557: better doctest
|
comment:7 Changed 6 years ago by
- Commit changed from 066afc235f2e14bccaec90493bd14c42659152b9 to 84734503c0cf6090a7411087aaae9564098d0547
Branch pushed to git repo; I updated commit sha1. New commits:
8473450 | trac #17557: clean import + Set -> frozenset in bibd.py
|
comment:8 Changed 6 years ago by
Replacing Set
with frozenset
in steiner_triple_system
I got a times 10 speedup (from 40ms to 4ms)!!
comment:9 in reply to: ↑ 6 ; follow-up: ↓ 11 Changed 6 years ago by
Yo !
The values from
0
to99
were already tested in a loop above. And it would be better if the specific valuev=136
is tested alone. See my commit.
Oh, sorry. But instead of this complicated loop with random values and the if to set the modulos right, could you just change the 100 to 400 ? It takes 3 seconds, and is way more systematic and easier to read.
Thanks for the speedup in steiner triple systems.
Nathann
comment:10 Changed 6 years ago by
- Commit changed from 84734503c0cf6090a7411087aaae9564098d0547 to 31cee6143c9157273d33dc1d311f288cc0eaf3b5
Branch pushed to git repo; I updated commit sha1. New commits:
31cee61 | trac #17557: doctest easier to read
|
comment:11 in reply to: ↑ 9 Changed 6 years ago by
Replying to ncohen:
Yo !
The values from
0
to99
were already tested in a loop above. And it would be better if the specific valuev=136
is tested alone. See my commit.Oh, sorry. But instead of this complicated loop with random values and the if to set the modulos right, could you just change the 100 to 400 ? It takes 3 seconds, and is way more systematic and easier to read.
Actually, I was wrong. The first test checks the function v_4_1_BIBD
while the second one checks designs.balanced_incomplete_block_design
. So it is fine to start again from 13
.
Vincent
comment:12 Changed 6 years ago by
Yooooooooo !
Well, I still don't know why you care so much about avoiding 13 BIBD of small size... Nor why you want to have a doctest for 136 right before having a doctest for 13-400.. But WELL, this is fixed :-D
Can we set it to positive review
or is there anything else ???
Thanks for your help,
Nathann
comment:13 Changed 6 years ago by
- Commit changed from 31cee6143c9157273d33dc1d311f288cc0eaf3b5 to 8dd05923ce7f06ddf314a9e3800d5deb5a32e2db
comment:14 Changed 6 years ago by
- Reviewers set to Vincent Delecroix
Forced push. You can set to positive review if you like it.
comment:15 Changed 6 years ago by
- Status changed from needs_review to positive_review
No objection ! Thanks !
Nathann
comment:16 Changed 6 years ago by
- Branch changed from u/vdelecroix/17557 to 8dd05923ce7f06ddf314a9e3800d5deb5a32e2db
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
trac #17555: Remove the dev scripts' documentation
trac #17557: creating a (136,4,1)-BIBD raises an exception