Opened 5 years ago

Closed 5 years ago

#17551 closed enhancement (fixed)

Rephrase the 'git the hard way' section of the developer's manual

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: documentation Keywords:
Cc: kcrisman, vdelecroix, tmonteil Merged in:
Authors: Nathann Cohen Reviewers: Jernej Azarija
Report Upstream: N/A Work issues:
Branch: dd9cb44 (Commits) Commit: dd9cb44905bfd2092fd71a2e8007415763152046
Dependencies: Stopgaps:

Description

Like for previous ones. More links, more lists, more bold text, shorter sentences.

Nathann

Change History (17)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17551
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to d8b911ea992cf4eecb44b285862d5bd46d469f6e

Branch pushed to git repo; I updated commit sha1. New commits:

d8b911etrac #17551: Rephrase the 'git the hard way' section of the developer's manual

comment:3 follow-up: Changed 5 years ago by vbraun

contrain -> contain

comment:4 Changed 5 years ago by git

  • Commit changed from d8b911ea992cf4eecb44b285862d5bd46d469f6e to 245c1cdbb918e8792e8ae96767188a4999007e50

Branch pushed to git repo; I updated commit sha1. New commits:

245c1cdtrac #17551: Typo

comment:5 in reply to: ↑ 3 Changed 5 years ago by ncohen

contrain -> contain

Done. Anything else before this can get in ?

Nathann

comment:6 follow-up: Changed 5 years ago by azi

Heey,

one more typo in terms of English grammar favorite -> favourite.

Other than that, I've read through the changes and it looks like you condensed the previous text and made it more clear?

Do you need any additional specific input about this patch?

comment:7 Changed 5 years ago by git

  • Commit changed from 245c1cdbb918e8792e8ae96767188a4999007e50 to b16f260251bfa5bc7a53552664e453e7fe3cc1d3

Branch pushed to git repo; I updated commit sha1. New commits:

b16f260trac #17551: Typo

comment:8 in reply to: ↑ 6 Changed 5 years ago by ncohen

Yooooooo !

one more typo in terms of English grammar favorite -> favourite.

Done.

Other than that, I've read through the changes and it looks like you condensed the previous text and made it more clear?

Yes, nothing more complicated. I am just trying to make several parts of the documentation more concise.

Do you need any additional specific input about this patch?

No, all that the patch needs now is a positive review :-P

Nathann

comment:9 follow-up: Changed 5 years ago by azi

There you go.

As far as I am concerned this contribution is good to go.

comment:10 Changed 5 years ago by azi

  • Reviewers set to azi
  • Status changed from needs_review to positive_review

comment:11 in reply to: ↑ 9 Changed 5 years ago by ncohen

  • Reviewers changed from azi to Jernej Azarija

As far as I am concerned this contribution is good to go.

THaaaaaaaaaaaaaanks !!!

Nathann

P.S.: the reviewer/author fields are meant to contain full names.

comment:12 Changed 5 years ago by vbraun

Both favourite and favorite are acceptable spellings (British vs. American English, same as colour vs color).

comment:13 Changed 5 years ago by azi

ooh, didn't know that :-O

What I usually do when I am not sure about the spelling is to type the word in google and see if it says "did you mean <corrected version>?"

comment:14 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Conflicts with #17534

comment:15 Changed 5 years ago by git

  • Commit changed from b16f260251bfa5bc7a53552664e453e7fe3cc1d3 to dd9cb44905bfd2092fd71a2e8007415763152046

Branch pushed to git repo; I updated commit sha1. New commits:

4ae1934trac #17534: The reviewer's checklist
a4615b0trac #17534: Reviewers' comments
375d087trac #17534: Reviewer's comments
4ff64c1trac #17534: Reviewer's comments
79bbb56Final English and other fixes
dd9cb44trac #17551: Merged with #17534

comment:16 Changed 5 years ago by ncohen

  • Status changed from needs_work to positive_review

comment:17 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17551 to dd9cb44905bfd2092fd71a2e8007415763152046
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.